Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ray-tracing based target block for 1.13.2+ #3763

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Nov 9, 2020

Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes #3756

@JRoy JRoy added type: enhancement Features and feature requests. type: bugfix PRs that fix bugs in EssentialsX. labels Nov 9, 2020
@JRoy JRoy added this to the 2.18.2 milestone Nov 9, 2020
@JRoy JRoy requested a review from mdcfe November 9, 2020 15:32
@mdcfe mdcfe merged commit 5b0c2a4 into EssentialsX:2.x Nov 9, 2020
@mdcfe mdcfe deleted the raytrace-target-block branch November 9, 2020 16:38
Chew pushed a commit to Chew/Essentials that referenced this pull request Nov 25, 2020
Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes EssentialsX#3756.
DarkEyeDragon pushed a commit to DarkEyeDragon/Essentials that referenced this pull request Dec 24, 2020
Uses new method of ray-tracing to target block instead of using BlockIterator which doesn't respect the player looking at a different y-level. Falls back to old BlockIterator method on server versions older than 1.13.2

Fixes EssentialsX#3756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix PRs that fix bugs in EssentialsX. type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editsign does not always edit the targeted sign
2 participants