Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Module #3844

Merged
merged 182 commits into from
Jul 1, 2021
Merged

Discord Module #3844

merged 182 commits into from
Jul 1, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Dec 19, 2020

EssentialsXDiscord

A discord <-> mc bridge that aims to be stupidly simple without bloat

Permissions

  • essentials.discord.receive.<group> - Allows user to receive chat messages from the specified discord channel
  • essentials.discord.markdown - Allows user to bypass the discord markdown filter
  • essentials.discord.ping - Allows user to ping everyone/role/here from mc in discord (bypass ping filters)

Docs: https://github.com/EssentialsX/Essentials/blob/module/discord/EssentialsDiscord/README.md

Continuation of #2488 & #3283

Closes #3129

@JRoy JRoy added the type: enhancement Features and feature requests. label Dec 19, 2020
@JRoy JRoy added this to the 2.19.0 milestone Dec 19, 2020
@JRoy JRoy added this to In progress in Discord module via automation Dec 19, 2020
@JRoy JRoy marked this pull request as draft December 19, 2020 05:26
mdcfe
mdcfe previously requested changes Jun 29, 2021
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

@JRoy JRoy requested a review from mdcfe June 29, 2021 14:15
darbyjack
darbyjack previously approved these changes Jun 30, 2021
@JRoy JRoy dismissed mdcfe’s stale review June 30, 2021 15:42

concerns addressed

mdcfe
mdcfe previously approved these changes Jun 30, 2021
pop4959
pop4959 previously approved these changes Jun 30, 2021
@JRoy JRoy dismissed stale reviews from pop4959, mdcfe, and darbyjack via dfa0ecd July 1, 2021 13:36
@JRoy JRoy changed the title Discord Module: Third Time's a Charm Discord Module Jul 1, 2021
@JRoy JRoy merged commit 0861427 into 2.x Jul 1, 2021
Discord module automation moved this from In progress to Done Jul 1, 2021
@JRoy JRoy deleted the module/discord branch July 1, 2021 13:43
@Andre601
Copy link
Contributor

Andre601 commented Jul 1, 2021

🎉

@JRoy
Copy link
Member Author

JRoy commented Jul 1, 2021

Thanks to all the reviewers and people who gave feedback along the way ❤️

@JRoy JRoy restored the module/discord branch July 1, 2021 22:22
@JRoy JRoy deleted the module/discord branch July 3, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: discord Issues or PRs for the EssentialsDiscord module type: enhancement Features and feature requests.
Projects
Development

Successfully merging this pull request may close these issues.

EssentialsXMPP but with Discord
9 participants