Fix AlternativeCommandsHandler not detecting some aliases #3856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
AlternativeCommandsHandler
would iterate through all the values of the command map rather than going by the keys. This should work with 99.99999% of plugins but for some god forsaken reason Towny (go figures) hides its aliases from Bukkit for the/town
command, exclusively. This causes Essentials to not be able to detect the/t
alias and therefore not be able to forward it. The new solution was to iterate over all keys in the known commands map which contains all aliases at time of registration and maps them to aCommand
object. This, for some reason, recognizes the/t
alias for Towny's/town
command and all is right in the world.Also included in this PR;
1.16.4
peer-not-authenticated
errors from time to time otherwise