Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault provider account creation #4147

Merged
merged 4 commits into from May 13, 2021
Merged

Fix vault provider account creation #4147

merged 4 commits into from May 13, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented May 13, 2021

Vault sux, read commit descriptions

JRoy added 2 commits May 12, 2021 20:24
This check swallowed any warnings spit out by UserMap#trackUUID causing problems
for plugins which didn't check the success of this method and thus leading to
possible stack overflow exceptions or other unexpected behavior
…Account

Complete oversight as I was under the impression tracking the UUID would create
the files for us.

We do moderate amounts of trolling.
@JRoy JRoy added the type: bugfix PRs that fix bugs in EssentialsX. label May 13, 2021
@JRoy JRoy added this to the 2.19.0 milestone May 13, 2021
@JRoy JRoy changed the title Fixup some things from the Vault provider Fix vault provider account creation May 13, 2021
@JRoy JRoy enabled auto-merge (squash) May 13, 2021 00:34
@JRoy JRoy merged commit 8a8d45c into 2.x May 13, 2021
@JRoy JRoy deleted the fix/extraneous-account-check branch May 13, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants