Cache overridden-commands and player-commands in Settings #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triagonal
added
module: main
JRoy
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes a regression introduced in #4072. Closes #4337.
Details
Proposed fix:
This PR changes
Settingsto cache theoverridden-commandsandplayer-commandslists inSettings.Since #4072,
EssentialsPlayerListener.CommandSendListenerhas incurred a significant performance penalty, as the Configurate rewrite inadvertently removed caching of these two lists.Environments tested:
OS: TODO
Java version: TODO
CraftBukkit 1.8.8should be functionally identical to 1.12.2Demonstration:
See comments on #4337 for more details.