Normalize legacy text before deserializing #5710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop4959
added
type: bugfix
|
I have no clue how the economy test is failing since it has literally nothing to do with this change. |
|
Never mind, apparently it does touch it somehow and it's 3 am so I'm being dumb. |
|
Better impl in #5711. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like Adventure's legacy deserializer does not like it when color codes are capitalized. Unfortunately this is quite common, and exposed to users (e.g. nicknames). Normalize this.
Ideally fixed in the serializer, but this should work fine as a hotfix.
Fixes #5708, #5709.