Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure translatable placeholders for gamemode in cantGamemode key #5771

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

ImDarkLaw
Copy link
Contributor

Information

This PR fixes #5763

Details

Proposed fix:
Make gamemode placeholder translatable in cantGamemode key.

Environments tested:

OS: Windows 11

Java version: OpenJDK Runtime Environment Corretto-21.0.2.13.1

  • Most recent Paper version (1.20.4, git-Paper-496)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

@pop4959 pop4959 added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Apr 28, 2024
@pop4959 pop4959 enabled auto-merge (squash) April 28, 2024 08:42
@pop4959 pop4959 merged commit 549283a into EssentialsX:2.x Apr 28, 2024
1 check passed
JRoy pushed a commit to jpenilla/Essentials that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cantGamemode message doesn't return the translated values for gamemodes
2 participants