Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for serde #19

Open
Tudyx opened this issue Aug 29, 2022 · 4 comments
Open

Add support for serde #19

Tudyx opened this issue Aug 29, 2022 · 4 comments

Comments

@Tudyx
Copy link
Contributor

Tudyx commented Aug 29, 2022

In can be cool to add serde under a feature flag and provide Serialize / Deserialize for comon type such as

  • NetworkInterface
  • Addr
  • V4IfAddr
  • V6IfAddr

I'm a little busy right now, but in couple of week maybe i will have some times to tackle this myself
@EstebanBorai
Copy link
Owner

Hi @Tudyx!

Sounds great in my opinion! As this is not an urgent feature I can wait for you if you want to work on this.
Otherwise let me know and I will be happy to work on it.

Thanks for opening this issue!

EstebanBorai added a commit that referenced this issue Aug 30, 2022
@EstebanBorai
feat: serde serialization/deserialization support
2bda17b 
Provides an optional feature to support `serde` for serializing
and deserializing `NetworkInterface`, `Addr`, `V4IfAddr`, `V6IfAddr`.

Resolves: #19
@EstebanBorai EstebanBorai mentioned this issue Aug 30, 2022
Closed
@EstebanBorai
Copy link
Owner

Hi @Tudyx, this morning I had some time to address this feature request and opened this PR: #20

I would love to get some feedback from you.
Thanks in advance.

@Tudyx
Copy link
Contributor Author

Tudyx commented Aug 31, 2022

Hi @EstebanBorai, thank you for finding the time to address this. I've left you some feedback in the PR #20

@EstebanBorai
Copy link
Owner

Hi @Tudyx!

I have been very busy and haven't found enough time to finish the PR on #20 which lacks of Deserialization support.
If you consider you want to give it a shot just go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: serde serialization/deserialization support EstebanBorai/network-interface
2 participants
@EstebanBorai @Tudyx