-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONE] Check extesion allowed video filename #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci pour la contribution !
demande de modification : amélioration de l'indentation, retrait de jquery.
data.submit(); | ||
var allow_extension_array = this.accept.replaceAll(' ', '').split(","); | ||
var extension = data.originalFiles[0].name.substr((data.originalFiles[0].name.lastIndexOf('.') +1)).toLowerCase(); | ||
if ($.inArray("."+extension,allow_extension_array) == -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ fonction jquery qui ne doit plus etre utilisé ! :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
à priori ceci devrait être équivalent :
if (allow_extension_array.includes("."+extension) == false) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solve (merci pour l'aide)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en gros, même remarques que Nicolas : tant qu'on peut éviter Jquery c'est mieux ;)
data.submit(); | ||
var allow_extension_array = this.accept.replaceAll(' ', '').split(","); | ||
var extension = data.originalFiles[0].name.substr((data.originalFiles[0].name.lastIndexOf('.') +1)).toLowerCase(); | ||
if ($.inArray("."+extension,allow_extension_array) == -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
à priori ceci devrait être équivalent :
if (allow_extension_array.includes("."+extension) == false) {
Remove jquery part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok pour moi, merci !
} | ||
var elementsShowProcessing = document.getElementsByClassName("show-on-processing"); | ||
for (let i = 0; i < elementsShowProcessing.length; i++) { | ||
elementsShowProcessing[i].style.display = 'block'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ici, il est préférable de retirer la classe "d-none" plutot que d'ajouter un style inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nous avons regardé mais ces elements n'ont pas la classe d-none ! Ils ont juste un style display=none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne comprend pas : le d-none vient juste d'etre ajouté 2 lignes plus haut o_O
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Ligne 178)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce ne sont pas les mêmes éléments ! (show-on-processing et hide-on-processing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ils devaient bien avoir un display block avec JQ, mais maintenant qu'on a corrigé, y'a pas de raison
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok pour toi ? au pire on merge et on améliore mais on pourra pas retirer jquery de cette page car on en a besoin pour le chuncked upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce ne sont pas les mêmes éléments ! (show-on-processing et hide-on-processing)
aaaah oki, j'avais pas vu, My bad !
Je valide ;)
* Check extesion allowed video filename * Update add_video.html Remove jquery part
Before sending your pull request, make sure the following are done :
develop
branch.[WIP]
or[DONE]
.