Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Pampletousse/fix add bulk update test #1042

Merged
merged 23 commits into from
Feb 6, 2024
Merged

[DONE] Pampletousse/fix add bulk update test #1042

merged 23 commits into from
Feb 6, 2024

Conversation

pampletousse
Copy link
Collaborator

No description provided.

pampletousse and others added 21 commits January 31, 2024 14:57
@pampletousse
Change default sort dashboard videos title into date_added
5f96626
@pampletousse
Merge branch 'develop' of https://github.com/EsupPortail/Esup-Pod int…
3b371f1 
…o develop
@pampletousse
Try to add new test for bulk_update function
f2f8659
@pampletousse
Add status code and use bulk_update function
0586f63
@pampletousse
Try to add user
72b2fed
@pampletousse
Resolve format json
0ebc542
@pampletousse
User fix
ff0baf1
@pampletousse
Try to dumps data
229dba8
@pampletousse
Remove json stringigy and loads on simple string parameter
94c2a95
@pampletousse
Replace file with Badatos's version
a82e00a
@pampletousse
Add Language Code variable to wsgirequest
d89787a
@pampletousse
Add Language Code variable to wsgirequest again
79c5159
@pampletousse
Try to use TransactionTestCase
527b64a
@pampletousse
Add len function to assertion
55742eb
@pampletousse
Try to fix test with pk instead of id + remove tear down on blocking …
8a77439 
…test
@pampletousse
Try to fix unique constraint error with serialized_rollback
257c53a
@pampletousse
Try to fix unique constraint error with tearDown class
cf8246b
@pampletousse
Try to fix video_update_owner test removing futures.theadpoolexecutor
fdcadd9
@pampletousse
Fix pep8
dccd5bc
@pampletousse
Remove unused import, add pydoc + try to fix pep8
1b77e54
@pampletousse
Rollback change function change_owner + change values in test
4c5e411
@pampletousse pampletousse changed the title [WIP] Pampletousse/fix add bulk update test [DONE] Pampletousse/fix add bulk update test Feb 6, 2024
AymericJak
AymericJak requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un petit changement et c'est bon pour moi

pod/video/views.py Outdated Show resolved Hide resolved
SebastienCozeDev
SebastienCozeDev requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@SebastienCozeDev SebastienCozeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette contribution ! Une petite chose à changer selon moi

pod/video/views.py Outdated Show resolved Hide resolved
@ptitloup
Update views.py
1618f73 
Add typing and change number to int
AymericJak
AymericJak requested changes Feb 6, 2024
View reviewed changes
pod/video/views.py Outdated Show resolved Hide resolved
SebastienCozeDev
SebastienCozeDev requested changes Feb 6, 2024
View reviewed changes
pod/video/views.py Outdated Show resolved Hide resolved
@ptitloup
Update views.py
40f20c0 
remove ":"
ptitloup
ptitloup approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi

SebastienCozeDev
SebastienCozeDev approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@SebastienCozeDev SebastienCozeDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi

AymericJak
AymericJak approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon aussi pour moi :)

@ptitloup ptitloup merged commit dcc0489 into EsupPortail:develop Feb 6, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitloup ptitloup ptitloup approved these changes

@SebastienCozeDev SebastienCozeDev SebastienCozeDev approved these changes

@AymericJak AymericJak AymericJak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pampletousse @ptitloup @SebastienCozeDev @AymericJak