Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Ptitloup/feature add video token #1052

Merged
merged 12 commits into from Feb 15, 2024
Merged

[DONE] Ptitloup/feature add video token #1052

merged 12 commits into from Feb 15, 2024

Conversation

ptitloup
Copy link
Contributor

@ptitloup ptitloup commented Feb 13, 2024 •
edited

Before sending your pull request, make sure the following are done :

  • You have read our contribution guidelines.
  • Your PR targets the develop branch.
  • The title of your PR starts with [WIP] or [DONE].
  • Add Model to store token
  • Add view to manage it
  • Add it in admin
  • Add access to video with token
  • Translation
  • Add unit test for model
  • Add unit test for manage token view
  • Add unit test to test video access with token

@ptitloup ptitloup self-assigned this Feb 13, 2024
@ptitloup ptitloup added the enhancement New feature or request label Feb 13, 2024
@ptitloup ptitloup linked an issue Feb 13, 2024 that may be closed by this pull request
Avoir plusieurs tocken pour accèder à une vidéo privée #1050
Closed
@ptitloup ptitloup changed the title [WIP] Ptitloup/feature add video token [DONE] Ptitloup/feature add video token Feb 14, 2024
Badatos
Badatos requested changes Feb 14, 2024
View reviewed changes
pod/locale/fr/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
pod/video/admin.py Outdated Show resolved Hide resolved
pod/video/templates/videos/video-info.html Outdated Show resolved Hide resolved
pod/video/templates/videos/video_access_tokens.html Outdated Show resolved Hide resolved
pod/video/templates/videos/video_access_tokens.html Outdated Show resolved Hide resolved
pod/video/templates/videos/video_access_tokens.html Outdated Show resolved Hide resolved
pod/video/templates/videos/video_access_tokens.html Outdated Show resolved Hide resolved
pod/video/tests/test_models.py Show resolved Hide resolved
pod/video/tests/test_models.py Outdated Show resolved Hide resolved
pod/video/tests/test_views.py
"initial_data.json",
]

def setUp(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem : bien noter que setup est réexecuté avant chaque test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui et donc il faut créer à chaque fois la video pour qu'elle soit retrouvée dans les tests...

def setUp(self):
        user = User.objects.create(username="pod", password="pod1234pod")
        print("VIDEO : %s" % Video.objects.all().count())
        [...]

Renvoie à chaque passage 0 même si une vidéo a été créé lors du précédent passage...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre. Dans les tests de vidéo encode on n’encore les video qu’une seule fois c’est permanent au sein des tests de la même classe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm à voir mais en attendant, tu peux valider ma PR :)

SebastienCozeDev
SebastienCozeDev requested changes Feb 15, 2024
View reviewed changes
pod/video/admin.py Show resolved Hide resolved
pod/video/views.py Outdated Show resolved Hide resolved
SebastienCozeDev
SebastienCozeDev requested changes Feb 15, 2024
View reviewed changes
pod/video/views.py Outdated Show resolved Hide resolved
Badatos
Badatos approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi :)

@ptitloup ptitloup merged commit 6fd6734 into develop Feb 15, 2024
1 of 4 checks passed
vsabatie added a commit to vsabatie/Pod that referenced this pull request Feb 15, 2024
@vsabatie
Squashed commit of the following:
bfd2728 
commit 793d1d0
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 13:29:30 2024 +0000

    Fixup. Format code with Black

commit 6fd6734
Author: Ptitloup <nicolas.can@univ-lille.fr>
Date:   Thu Feb 15 14:28:59 2024 +0100

    [DONE] Ptitloup/feature add video token (EsupPortail#1052)

    * add video token models, add it in admin, add view to manage token, call it from edit and views template

    * add access to video with token, improve token list display and add translation

    * fix indent

    * add uniq constraints for video access token, add unit test for video access token model, fix translate

    * add unit test for view, complete unit test for model, improve access token view

    * add copy to clipboard icon, add video access test view

    * add js to copy link and embed value

    * change col size and align middle

    * improve indent, add translation and pydoc

    * add info to delete token

commit c104e93
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 10:14:37 2024 +0000

    Fixup. Format code with Black

commit ac8bf7e
Author: pampletousse <51699553+pampletousse@users.noreply.github.com>
Date:   Thu Feb 15 11:14:10 2024 +0100

    [DONE] Pampletousse/fix improve bulk update tests (EsupPortail#1053)

    * Change default sort dashboard videos title into date_added

    * Change title to type test and add owner test

    * Change get videos objects

    * Change values for owner test

    * Change user for post request

    * Add test_bulk_update_tags and fix owner bulk update (missing move file)

    * Fix pep8

    * Try to repair test_update_video_owner

    * Change order of tests + add bulk_delete test

    * Try to repair bulk_delete test

    * Try to repair bulk_delete test with user3 videos

    * add response check of bulk_delete failure

    * Fix bad value sending to change owner

    * Fix again test_views not working

    * Add doc on test_update_video_owner

    ---------

    Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

commit 033f7ae
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:39 2024 +0000

    Auto-update configuration files

commit d588781
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:17 2024 +0000

    Fixup. Format code with Black

commit 8770413
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:08 2024 +0000

    Fixup. Format code with Prettier

commit 2d982a8
Author: Olivier Bado-Faustin <bado@unice.fr>
Date:   Thu Feb 15 10:23:39 2024 +0100

    [DONE] Fix dressing Watermark path (EsupPortail#1048)

    * * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
    * Some code formatting & docs

    * Send email to admin on encoding error

    * * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

    * another try to run setup only once

    * Fix small bug

    * correct typo

    * small correction

    * modify encoding test

    * * Polish `change video owner` template
    * move every "mandatory fields" help messagre in a main template to be included
    * Small change on encoding error handling

    * Minor QoC

    * correct typos

    * Corrections after peer review:
    * Use django url block
    * Use {{ owner }} and {{ user }} default str
    * Various QoC

    * Add missing parameter types

    * Specify types of some lists in functions hints

    * Remove every list content type hint, as they appear only in python >= 3.9
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Feb 15, 2024
@ptitloup @vsabatie
[DONE] Ptitloup/feature add video token (EsupPortail#1052)
e771fe6 
* add video token models, add it in admin, add view to manage token, call it from edit and views template

* add access to video with token, improve token list display and add translation

* fix indent

* add uniq constraints for video access token, add unit test for video access token model, fix translate

* add unit test for view, complete unit test for model, improve access token view

* add copy to clipboard icon, add video access test view

* add js to copy link and embed value

* change col size and align middle

* improve indent, add translation and pydoc

* add info to delete token
vsabatie added a commit to vsabatie/Pod that referenced this pull request Feb 15, 2024
@vsabatie
Squashed commit of the following:
f907590 
commit 793d1d0
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 13:29:30 2024 +0000

    Fixup. Format code with Black

commit 6fd6734
Author: Ptitloup <nicolas.can@univ-lille.fr>
Date:   Thu Feb 15 14:28:59 2024 +0100

    [DONE] Ptitloup/feature add video token (EsupPortail#1052)

    * add video token models, add it in admin, add view to manage token, call it from edit and views template

    * add access to video with token, improve token list display and add translation

    * fix indent

    * add uniq constraints for video access token, add unit test for video access token model, fix translate

    * add unit test for view, complete unit test for model, improve access token view

    * add copy to clipboard icon, add video access test view

    * add js to copy link and embed value

    * change col size and align middle

    * improve indent, add translation and pydoc

    * add info to delete token

commit c104e93
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 10:14:37 2024 +0000

    Fixup. Format code with Black

commit ac8bf7e
Author: pampletousse <51699553+pampletousse@users.noreply.github.com>
Date:   Thu Feb 15 11:14:10 2024 +0100

    [DONE] Pampletousse/fix improve bulk update tests (EsupPortail#1053)

    * Change default sort dashboard videos title into date_added

    * Change title to type test and add owner test

    * Change get videos objects

    * Change values for owner test

    * Change user for post request

    * Add test_bulk_update_tags and fix owner bulk update (missing move file)

    * Fix pep8

    * Try to repair test_update_video_owner

    * Change order of tests + add bulk_delete test

    * Try to repair bulk_delete test

    * Try to repair bulk_delete test with user3 videos

    * add response check of bulk_delete failure

    * Fix bad value sending to change owner

    * Fix again test_views not working

    * Add doc on test_update_video_owner

    ---------

    Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

commit 033f7ae
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:39 2024 +0000

    Auto-update configuration files

commit d588781
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:17 2024 +0000

    Fixup. Format code with Black

commit 8770413
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:08 2024 +0000

    Fixup. Format code with Prettier

commit 2d982a8
Author: Olivier Bado-Faustin <bado@unice.fr>
Date:   Thu Feb 15 10:23:39 2024 +0100

    [DONE] Fix dressing Watermark path (EsupPortail#1048)

    * * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
    * Some code formatting & docs

    * Send email to admin on encoding error

    * * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

    * another try to run setup only once

    * Fix small bug

    * correct typo

    * small correction

    * modify encoding test

    * * Polish `change video owner` template
    * move every "mandatory fields" help messagre in a main template to be included
    * Small change on encoding error handling

    * Minor QoC

    * correct typos

    * Corrections after peer review:
    * Use django url block
    * Use {{ owner }} and {{ user }} default str
    * Various QoC

    * Add missing parameter types

    * Specify types of some lists in functions hints

    * Remove every list content type hint, as they appear only in python >= 3.9
@ptitloup ptitloup deleted the ptitloup/feature_add_video_token branch April 8, 2024 14:23
ptitloup added a commit that referenced this pull request Apr 10, 2024
@fanfounet @vsabatie
@Badatos @pampletousse @ptitloup
[DONE] WEBTV - feature dynamic home page (#1082)
cc21f8e 
* feature for a dyanamic home page

* flake

* fix model

* fixe lang

* compilemessages

* init data

* fix

* little fixes

* black formatter

* [DONE] Fix dressing Watermark path (#1048)

* * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
* Some code formatting & docs

* Send email to admin on encoding error

* * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

* another try to run setup only once

* Fix small bug

* correct typo

* small correction

* modify encoding test

* * Polish `change video owner` template
* move every "mandatory fields" help messagre in a main template to be included
* Small change on encoding error handling

* Minor QoC

* correct typos

* Corrections after peer review:
* Use django url block
* Use {{ owner }} and {{ user }} default str
* Various QoC

* Add missing parameter types

* Specify types of some lists in functions hints

* Remove every list content type hint, as they appear only in python >= 3.9

* Fixup. Format code with Prettier

* Fixup. Format code with Black

* Auto-update configuration files

* first correction after the first review

* Squashed commit of the following:

commit c104e93
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 10:14:37 2024 +0000

    Fixup. Format code with Black

commit ac8bf7e
Author: pampletousse <51699553+pampletousse@users.noreply.github.com>
Date:   Thu Feb 15 11:14:10 2024 +0100

    [DONE] Pampletousse/fix improve bulk update tests (#1053)

    * Change default sort dashboard videos title into date_added

    * Change title to type test and add owner test

    * Change get videos objects

    * Change values for owner test

    * Change user for post request

    * Add test_bulk_update_tags and fix owner bulk update (missing move file)

    * Fix pep8

    * Try to repair test_update_video_owner

    * Change order of tests + add bulk_delete test

    * Try to repair bulk_delete test

    * Try to repair bulk_delete test with user3 videos

    * add response check of bulk_delete failure

    * Fix bad value sending to change owner

    * Fix again test_views not working

    * Add doc on test_update_video_owner

    ---------

    Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

commit 033f7ae
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:39 2024 +0000

    Auto-update configuration files

commit d588781
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:17 2024 +0000

    Fixup. Format code with Black

commit 8770413
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:08 2024 +0000

    Fixup. Format code with Prettier

commit 2d982a8
Author: Olivier Bado-Faustin <bado@unice.fr>
Date:   Thu Feb 15 10:23:39 2024 +0100

    [DONE] Fix dressing Watermark path (#1048)

    * * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
    * Some code formatting & docs

    * Send email to admin on encoding error

    * * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

    * another try to run setup only once

    * Fix small bug

    * correct typo

    * small correction

    * modify encoding test

    * * Polish `change video owner` template
    * move every "mandatory fields" help messagre in a main template to be included
    * Small change on encoding error handling

    * Minor QoC

    * correct typos

    * Corrections after peer review:
    * Use django url block
    * Use {{ owner }} and {{ user }} default str
    * Various QoC

    * Add missing parameter types

    * Specify types of some lists in functions hints

    * Remove every list content type hint, as they appear only in python >= 3.9

* [DONE] Fix dressing Watermark path (#1048)

* * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
* Some code formatting & docs

* Send email to admin on encoding error

* * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

* another try to run setup only once

* Fix small bug

* correct typo

* small correction

* modify encoding test

* * Polish `change video owner` template
* move every "mandatory fields" help messagre in a main template to be included
* Small change on encoding error handling

* Minor QoC

* correct typos

* Corrections after peer review:
* Use django url block
* Use {{ owner }} and {{ user }} default str
* Various QoC

* Add missing parameter types

* Specify types of some lists in functions hints

* Remove every list content type hint, as they appear only in python >= 3.9

* Fixup. Format code with Prettier

* Fixup. Format code with Black

* [DONE] Pampletousse/fix improve bulk update tests (#1053)

* Change default sort dashboard videos title into date_added

* Change title to type test and add owner test

* Change get videos objects

* Change values for owner test

* Change user for post request

* Add test_bulk_update_tags and fix owner bulk update (missing move file)

* Fix pep8

* Try to repair test_update_video_owner

* Change order of tests + add bulk_delete test

* Try to repair bulk_delete test

* Try to repair bulk_delete test with user3 videos

* add response check of bulk_delete failure

* Fix bad value sending to change owner

* Fix again test_views not working

* Add doc on test_update_video_owner

---------

Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

* Fixup. Format code with Black

* compilemessages

* make lang + compilemessages

* Squashed commit of the following:

commit 793d1d0
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 13:29:30 2024 +0000

    Fixup. Format code with Black

commit 6fd6734
Author: Ptitloup <nicolas.can@univ-lille.fr>
Date:   Thu Feb 15 14:28:59 2024 +0100

    [DONE] Ptitloup/feature add video token (#1052)

    * add video token models, add it in admin, add view to manage token, call it from edit and views template

    * add access to video with token, improve token list display and add translation

    * fix indent

    * add uniq constraints for video access token, add unit test for video access token model, fix translate

    * add unit test for view, complete unit test for model, improve access token view

    * add copy to clipboard icon, add video access test view

    * add js to copy link and embed value

    * change col size and align middle

    * improve indent, add translation and pydoc

    * add info to delete token

commit c104e93
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 10:14:37 2024 +0000

    Fixup. Format code with Black

commit ac8bf7e
Author: pampletousse <51699553+pampletousse@users.noreply.github.com>
Date:   Thu Feb 15 11:14:10 2024 +0100

    [DONE] Pampletousse/fix improve bulk update tests (#1053)

    * Change default sort dashboard videos title into date_added

    * Change title to type test and add owner test

    * Change get videos objects

    * Change values for owner test

    * Change user for post request

    * Add test_bulk_update_tags and fix owner bulk update (missing move file)

    * Fix pep8

    * Try to repair test_update_video_owner

    * Change order of tests + add bulk_delete test

    * Try to repair bulk_delete test

    * Try to repair bulk_delete test with user3 videos

    * add response check of bulk_delete failure

    * Fix bad value sending to change owner

    * Fix again test_views not working

    * Add doc on test_update_video_owner

    ---------

    Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

commit 033f7ae
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:39 2024 +0000

    Auto-update configuration files

commit d588781
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:17 2024 +0000

    Fixup. Format code with Black

commit 8770413
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:08 2024 +0000

    Fixup. Format code with Prettier

commit 2d982a8
Author: Olivier Bado-Faustin <bado@unice.fr>
Date:   Thu Feb 15 10:23:39 2024 +0100

    [DONE] Fix dressing Watermark path (#1048)

    * * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
    * Some code formatting & docs

    * Send email to admin on encoding error

    * * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

    * another try to run setup only once

    * Fix small bug

    * correct typo

    * small correction

    * modify encoding test

    * * Polish `change video owner` template
    * move every "mandatory fields" help messagre in a main template to be included
    * Small change on encoding error handling

    * Minor QoC

    * correct typos

    * Corrections after peer review:
    * Use django url block
    * Use {{ owner }} and {{ user }} default str
    * Various QoC

    * Add missing parameter types

    * Specify types of some lists in functions hints

    * Remove every list content type hint, as they appear only in python >= 3.9

* compilemessages

* make lang

* test reset lang

* + nl

* [DONE] Fix dressing Watermark path (#1048)

* * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
* Some code formatting & docs

* Send email to admin on encoding error

* * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

* another try to run setup only once

* Fix small bug

* correct typo

* small correction

* modify encoding test

* * Polish `change video owner` template
* move every "mandatory fields" help messagre in a main template to be included
* Small change on encoding error handling

* Minor QoC

* correct typos

* Corrections after peer review:
* Use django url block
* Use {{ owner }} and {{ user }} default str
* Various QoC

* Add missing parameter types

* Specify types of some lists in functions hints

* Remove every list content type hint, as they appear only in python >= 3.9

* [DONE] Pampletousse/fix improve bulk update tests (#1053)

* Change default sort dashboard videos title into date_added

* Change title to type test and add owner test

* Change get videos objects

* Change values for owner test

* Change user for post request

* Add test_bulk_update_tags and fix owner bulk update (missing move file)

* Fix pep8

* Try to repair test_update_video_owner

* Change order of tests + add bulk_delete test

* Try to repair bulk_delete test

* Try to repair bulk_delete test with user3 videos

* add response check of bulk_delete failure

* Fix bad value sending to change owner

* Fix again test_views not working

* Add doc on test_update_video_owner

---------

Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

* [DONE] Ptitloup/feature add video token (#1052)

* add video token models, add it in admin, add view to manage token, call it from edit and views template

* add access to video with token, improve token list display and add translation

* fix indent

* add uniq constraints for video access token, add unit test for video access token model, fix translate

* add unit test for view, complete unit test for model, improve access token view

* add copy to clipboard icon, add video access test view

* add js to copy link and embed value

* change col size and align middle

* improve indent, add translation and pydoc

* add info to delete token

* Fixup. Format code with Black

* fixe lang

* little fixes

* [DONE] Fix dressing Watermark path (#1048)

* * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
* Some code formatting & docs

* Send email to admin on encoding error

* * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

* another try to run setup only once

* Fix small bug

* correct typo

* small correction

* modify encoding test

* * Polish `change video owner` template
* move every "mandatory fields" help messagre in a main template to be included
* Small change on encoding error handling

* Minor QoC

* correct typos

* Corrections after peer review:
* Use django url block
* Use {{ owner }} and {{ user }} default str
* Various QoC

* Add missing parameter types

* Specify types of some lists in functions hints

* Remove every list content type hint, as they appear only in python >= 3.9

* first correction after the first review

* [DONE] Fix dressing Watermark path (#1048)

* * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
* Some code formatting & docs

* Send email to admin on encoding error

* * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

* another try to run setup only once

* Fix small bug

* correct typo

* small correction

* modify encoding test

* * Polish `change video owner` template
* move every "mandatory fields" help messagre in a main template to be included
* Small change on encoding error handling

* Minor QoC

* correct typos

* Corrections after peer review:
* Use django url block
* Use {{ owner }} and {{ user }} default str
* Various QoC

* Add missing parameter types

* Specify types of some lists in functions hints

* Remove every list content type hint, as they appear only in python >= 3.9

* make lang + compilemessages

* Squashed commit of the following:

commit 793d1d0
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 13:29:30 2024 +0000

    Fixup. Format code with Black

commit 6fd6734
Author: Ptitloup <nicolas.can@univ-lille.fr>
Date:   Thu Feb 15 14:28:59 2024 +0100

    [DONE] Ptitloup/feature add video token (#1052)

    * add video token models, add it in admin, add view to manage token, call it from edit and views template

    * add access to video with token, improve token list display and add translation

    * fix indent

    * add uniq constraints for video access token, add unit test for video access token model, fix translate

    * add unit test for view, complete unit test for model, improve access token view

    * add copy to clipboard icon, add video access test view

    * add js to copy link and embed value

    * change col size and align middle

    * improve indent, add translation and pydoc

    * add info to delete token

commit c104e93
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 10:14:37 2024 +0000

    Fixup. Format code with Black

commit ac8bf7e
Author: pampletousse <51699553+pampletousse@users.noreply.github.com>
Date:   Thu Feb 15 11:14:10 2024 +0100

    [DONE] Pampletousse/fix improve bulk update tests (#1053)

    * Change default sort dashboard videos title into date_added

    * Change title to type test and add owner test

    * Change get videos objects

    * Change values for owner test

    * Change user for post request

    * Add test_bulk_update_tags and fix owner bulk update (missing move file)

    * Fix pep8

    * Try to repair test_update_video_owner

    * Change order of tests + add bulk_delete test

    * Try to repair bulk_delete test

    * Try to repair bulk_delete test with user3 videos

    * add response check of bulk_delete failure

    * Fix bad value sending to change owner

    * Fix again test_views not working

    * Add doc on test_update_video_owner

    ---------

    Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>

commit 033f7ae
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:39 2024 +0000

    Auto-update configuration files

commit d588781
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:17 2024 +0000

    Fixup. Format code with Black

commit 8770413
Author: github-actions <github-actions@github.com>
Date:   Thu Feb 15 09:24:08 2024 +0000

    Fixup. Format code with Prettier

commit 2d982a8
Author: Olivier Bado-Faustin <bado@unice.fr>
Date:   Thu Feb 15 10:23:39 2024 +0100

    [DONE] Fix dressing Watermark path (#1048)

    * * Replace `settings.BASE_DIR` by watermark.file.path for video dressing watermark
    * Some code formatting & docs

    * Send email to admin on encoding error

    * * Setup of Video & Audio encoding test case is only called once (This testCase will be 4x faster)

    * another try to run setup only once

    * Fix small bug

    * correct typo

    * small correction

    * modify encoding test

    * * Polish `change video owner` template
    * move every "mandatory fields" help messagre in a main template to be included
    * Small change on encoding error handling

    * Minor QoC

    * correct typos

    * Corrections after peer review:
    * Use django url block
    * Use {{ owner }} and {{ user }} default str
    * Various QoC

    * Add missing parameter types

    * Specify types of some lists in functions hints

    * Remove every list content type hint, as they appear only in python >= 3.9

* test reset lang

* fix last conflicts

* make lang

* make lang

* add visible field

* fix default block

* fix flake

* remove test events_next.html

* bugfix after review

* flake8 and unit test

* bugfix unit test

* add unit test and bugfix

* add unit test main views

* add unit test main views

* remove tempate last videos and some variables

* update after review

* fix error block template

* fix after review

* fix card_list and lang

* pydoc fix and translation

---------

Co-authored-by: Valentin Sabatier <valentin.sabatier@hotmail.fr>
Co-authored-by: Olivier Bado-Faustin <bado@unice.fr>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: pampletousse <51699553+pampletousse@users.noreply.github.com>
Co-authored-by: pampletousse <sylvain.loppin@grenet.fr>
Co-authored-by: Ptitloup <nicolas.can@univ-lille.fr>
Co-authored-by: Valentin Sabatier <62725910+vsabatie@users.noreply.github.com>
Co-authored-by: Charneau Franck <franck.charneau@univ-lr.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badatos Badatos Badatos approved these changes

@SebastienCozeDev SebastienCozeDev SebastienCozeDev approved these changes

@AymericJak AymericJak Awaiting requested review from AymericJak

Assignees

@ptitloup ptitloup

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoir plusieurs tocken pour accèder à une vidéo privée
3 participants
@ptitloup @Badatos @SebastienCozeDev