[DONE] Fix remote encoding and other stuff #1056

ptitloup · 2024-02-15T14:46:38Z

Before sending your pull request, make sure the following are done :

You have read our contribution guidelines.
Your PR targets the develop branch.
The title of your PR starts with [WIP] or [DONE].
Add unit test for video search utils
remove celery for encoding acquitement andd. rest view for record remote vdeo encoding
remove celery for transcoding aquitement
Add configuration
Fix get file CVE
Add unit test (try to up docker in github action)

…CODING - use store_remote_encoded_video to store video data at the end of encoding - fix discipline filter - change pod/video_encode_transcript/encoding_tasks.py to call store_remote_encoded_video in rest api

… old files

…o ptitloup/improve_remote_encoding

pod/main/views.py

Badatos

Pas bcp de code qui touche au front ici, donc pas trop ma spécialité mais globalement code ok pour moi ;)

pod/main/settings.py

.github/workflows/pod_encoding.yml

pod/main/test_settings.py

pod/video/rest_views.py

pod/video_encode_transcript/management/commands/test_encode_transcode.py

… the same db

pod/custom/settings_local_docker_full_test.py

pod/main/configuration.json

pod/custom/settings_local_docker_full_test.py

pod/main/configuration.json

AymericJak

Ok pour moi !

SebastienCozeDev

Tout est bon pour moi au niveau du code. Merci pour cette PR !

…o ptitloup/improve_remote_encoding

…ipting model and task

…o ptitloup/improve_remote_encoding

add test for video search utils

b7b3f64

ptitloup self-assigned this Feb 15, 2024

ptitloup marked this pull request as draft February 15, 2024 14:46

ptitloup added bug Something isn't working enhancement New feature or request labels Feb 15, 2024

test_index_and_delete_es

5e72e28

ptitloup changed the title ~~[WIP] add test for video search utils~~ [WIP] Fix remote encoding and other stuff Feb 16, 2024

ptitloup added 8 commits February 16, 2024 16:07

replace USE_DISTANT_ENCODING_TRANSCODING by USE_REMOTE_ENCODING_TRANS…

d5c5331

…CODING - use store_remote_encoded_video to store video data at the end of encoding - fix discipline filter - change pod/video_encode_transcript/encoding_tasks.py to call store_remote_encoded_video in rest api

remove import dressing in encode module to use it without django

cf742c5

remove unused import

8992213

remove unused import - fix pep8 compliance

0bcff67

move json calling to prevent none objeect

a7e2936

fix pep8

db7f62f

create rest view to importing transcript - call it from task - remove…

90ded7e

… old files

fix transcritping

db0210f

ptitloup requested review from Badatos and vsabatie February 20, 2024 12:37

ptitloup marked this pull request as ready for review February 20, 2024 12:37

ptitloup added 5 commits February 21, 2024 09:25

fix import transcript error

096d964

add new configuration

91dd821

Merge branch 'develop' of https://github.com/EsupPortail/Esup-Pod int…

de206d0

…o ptitloup/improve_remote_encoding

fix access token link

7fe669f

fix download file in main view

879b631

plegay reviewed Feb 22, 2024

View reviewed changes

pod/main/views.py Outdated Show resolved Hide resolved

ptitloup added 6 commits February 22, 2024 12:20

add test to remote encoding

677b55a

update docker

32fa355

add wait docker and show running container

8612930

add env file

a4a2b2f

split env and start container

5cdd9c1

start container on one line

4a4b1e9

ptitloup added 3 commits February 23, 2024 10:08

simple test to try

88abeb2

fix test for download file, add encode video

c8ffb57

fix pep8 and increase delay to encode

5518040

Badatos approved these changes Feb 23, 2024

View reviewed changes

ptitloup added 9 commits February 23, 2024 11:20

fix unit test and improve code after review

1c868b2

change test remote encode in unit test

49a24bf

change command to run test, add print

a487adf

call encode to prevent thread - check if run test and pod back run on…

8511cc2

… the same db

work on local - try on GH

3a047b6

Add token and specify url to call back at the end of encoding

7f54b4a

change ES version and fix pep8

1b3f718

fix token

a60d3ad

add staff status for user

0690d35

ptitloup changed the title ~~[WIP] Fix remote encoding and other stuff~~ [DONE] Fix remote encoding and other stuff Feb 23, 2024

ptitloup requested review from SebastienCozeDev and AymericJak February 23, 2024 18:35

AymericJak requested changes Feb 26, 2024

View reviewed changes

pod/custom/settings_local_docker_full_test.py Show resolved Hide resolved

pod/main/configuration.json Show resolved Hide resolved

SebastienCozeDev requested changes Feb 26, 2024

View reviewed changes

pod/custom/settings_local_docker_full_test.py Outdated Show resolved Hide resolved

pod/main/configuration.json Outdated Show resolved Hide resolved

pod/main/configuration.json Outdated Show resolved Hide resolved

Add some translations

1320798

AymericJak approved these changes Mar 1, 2024

View reviewed changes

SebastienCozeDev approved these changes Mar 1, 2024

View reviewed changes

ptitloup added 7 commits March 1, 2024 14:06

use covergae to run test

f0c4e36

Merge branch 'develop' of https://github.com/EsupPortail/Esup-Pod int…

33ee61c

…o ptitloup/improve_remote_encoding

fix conflict - fix pep8

639a7f9

add transcripting in test - change setting to do it - improve transcr…

eb2978f

…ipting model and task

change transcode by transcript !

9c6d19f

Merge branch 'develop' of https://github.com/EsupPortail/Esup-Pod int…

cf6f654

…o ptitloup/improve_remote_encoding

fix pep8 in test settings

e3b9513

ptitloup merged commit 935faac into develop Mar 1, 2024
6 checks passed

ptitloup deleted the ptitloup/improve_remote_encoding branch April 8, 2024 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DONE] Fix remote encoding and other stuff #1056

[DONE] Fix remote encoding and other stuff #1056

ptitloup commented Feb 15, 2024 •

edited

Badatos left a comment

AymericJak left a comment

SebastienCozeDev left a comment

[DONE] Fix remote encoding and other stuff #1056

[DONE] Fix remote encoding and other stuff #1056

Conversation

ptitloup commented Feb 15, 2024 • edited

Badatos left a comment

Choose a reason for hiding this comment

AymericJak left a comment

Choose a reason for hiding this comment

SebastienCozeDev left a comment

Choose a reason for hiding this comment

ptitloup commented Feb 15, 2024 •

edited