Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] Ptitloup/feature improve meeting #817

Merged
merged 11 commits into from
May 9, 2023
Merged

[DONE] Ptitloup/feature improve meeting #817

merged 11 commits into from
May 9, 2023

Conversation

ptitloup
Copy link
Contributor

@ptitloup ptitloup commented Apr 21, 2023 •
edited
Loading

  • add fieldset to show record field
  • add settings to specify default slide for meeting session
  • add slide field to meeting model

AymericJak
AymericJak reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit soucis au niveau des cards pour les meetings.

image

Testé en local, fonctionnel pour les enregistrements.

Néanmoins, pas trop compris pour l'affichage par défaut d'une présentation.

@ptitloup ptitloup changed the title [DONE] Ptitloup/feature improve meeting [WIP] Ptitloup/feature improve meeting May 3, 2023
@ptitloup ptitloup force-pushed the ptitloup/feature_improve_meeting branch from f713c90 to 4e23667 Compare May 4, 2023 09:29
@ptitloup ptitloup changed the title [WIP] Ptitloup/feature improve meeting [DONE] Ptitloup/feature improve meeting May 4, 2023
Badatos
Badatos approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai rien vu de choquant. ok pour moi.

@LoicBonavent LoicBonavent self-requested a review May 9, 2023 07:11
LoicBonavent
LoicBonavent approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@LoicBonavent LoicBonavent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le paramétrage MEETING_PRE_UPLOAD_SLIDES fonctionne parfaitement.

AymericJak
AymericJak requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@AymericJak AymericJak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avec le setting MEETING_PRE_UPLOAD_SLIDES = True.

Lorsque la réunion ne comporte pas de fichier 'slide', erreur suivante lors de l'ouverture de la réunion :

join() argument must be str or bytes, not 'bool'

De plus, il faudrait ajouter une vérification pour le formulaire d'ajout de réunion pour la taille du nom.
En effet, nous pouvons créer une réunion avec un nom de 1 caractère.
Puis lors de l'ouverture :
image

Nous ne comprenons pas vraiment comment tester les slides.
Où les slides seront-elles visibles ?

@ptitloup
Copy link
Contributor Author

ptitloup commented May 9, 2023

Merci pour ces retours, je vais regarder les problèmes remontés

@ptitloup
Copy link
Contributor Author

ptitloup commented May 9, 2023

Le paramètre MEETING_PRE_UPLOAD_SLIDES doit contenir le chemin vers les slides a afficher par défaut dans une session BBB. Si vous mettez un booleen, cela ne peut pas fonctionner ! :-)

@ptitloup
Copy link
Contributor Author

ptitloup commented May 9, 2023

je viens de rajouter un min validator pour le nom des réunions, merci de me dire @AymericJak si c'est ok avec ca.

AymericJak
AymericJak reviewed May 9, 2023
View reviewed changes
pod/meeting/models.py Outdated Show resolved Hide resolved
@ptitloup
Copy link
Contributor Author

ptitloup commented May 9, 2023

Merci à tous pour vos remarques

@ptitloup ptitloup merged commit ad034ff into develop May 9, 2023
4 checks passed
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request May 10, 2023
@ptitloup @vsabatie
[DONE] Ptitloup/feature improve meeting (EsupPortail#817)
2c654ec 
* new organisation for record fields - hide allow start-stop recording, default to True

* fix conflicts in translation

* add slides field to meeting model

* fix conflicts in translation 2

* end of create document url for slides

* put url document in https

* set limit size to 1 mega bytes

* add MEETING_PRE_UPLOAD_SLIDES in configuration

* add min length validator for meeting name

* put min size for meeting name to 2
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request May 10, 2023
@ptitloup @vsabatie
[DONE] Ptitloup/feature improve meeting (EsupPortail#817)
73f513c 
* new organisation for record fields - hide allow start-stop recording, default to True

* fix conflicts in translation

* add slides field to meeting model

* fix conflicts in translation 2

* end of create document url for slides

* put url document in https

* set limit size to 1 mega bytes

* add MEETING_PRE_UPLOAD_SLIDES in configuration

* add min length validator for meeting name

* put min size for meeting name to 2
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request May 10, 2023
@ptitloup @vsabatie
[DONE] Ptitloup/feature improve meeting (EsupPortail#817)
aff1b50 
* new organisation for record fields - hide allow start-stop recording, default to True

* fix conflicts in translation

* add slides field to meeting model

* fix conflicts in translation 2

* end of create document url for slides

* put url document in https

* set limit size to 1 mega bytes

* add MEETING_PRE_UPLOAD_SLIDES in configuration

* add min length validator for meeting name

* put min size for meeting name to 2
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request May 10, 2023
@ptitloup @vsabatie
[DONE] Ptitloup/feature improve meeting (EsupPortail#817)
e61d9c5 
* new organisation for record fields - hide allow start-stop recording, default to True

* fix conflicts in translation

* add slides field to meeting model

* fix conflicts in translation 2

* end of create document url for slides

* put url document in https

* set limit size to 1 mega bytes

* add MEETING_PRE_UPLOAD_SLIDES in configuration

* add min length validator for meeting name

* put min size for meeting name to 2
@ptitloup ptitloup deleted the ptitloup/feature_improve_meeting branch April 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AymericJak AymericJak AymericJak requested changes

@Badatos Badatos Badatos approved these changes

@LoicBonavent LoicBonavent LoicBonavent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ptitloup @Badatos @LoicBonavent @AymericJak