Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] add site id from settings #992

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[DONE] add site id from settings #992

merged 1 commit into from
Oct 25, 2023

Conversation

ptitloup
Copy link
Contributor

@ptitloup ptitloup commented Oct 23, 2023 •
edited

Before sending your pull request, make sure the following are done :

  • You have read our contribution guidelines.
  • Your PR targets the develop branch.
  • The title of your PR starts with [WIP] or [DONE].

@ptitloup
Copy link
Contributor Author

Je suis pas certain que cette PR seve à quelque chose maintenant car site est remplacé par get_current_site mais au cas ou !

@ptitloup ptitloup self-assigned this Oct 23, 2023
@ptitloup ptitloup added the enhancement New feature or request label Oct 23, 2023
Badatos
Badatos approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en effet mais c'est bien quand même ^^

@LoicBonavent LoicBonavent self-requested a review October 25, 2023 08:31
@ptitloup ptitloup merged commit 3ff2ad7 into develop Oct 25, 2023
5 checks passed
vsabatie pushed a commit to vsabatie/Pod that referenced this pull request Nov 22, 2023
@ptitloup @vsabatie
[DONE] add site id from settings (EsupPortail#992)
e7ecf51
@ptitloup ptitloup deleted the ptitloup/add_site_id branch April 8, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badatos Badatos Badatos approved these changes

@LoicBonavent LoicBonavent LoicBonavent approved these changes

Assignees

@ptitloup ptitloup

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ptitloup @Badatos @LoicBonavent