Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise quote html #93

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Standardise quote html #93

merged 1 commit into from
Jan 17, 2022

Conversation

Newnab
Copy link
Member

@Newnab Newnab commented Jan 17, 2022

To bring our multiple quote outputs into one standardised default output, which meets the HTML spec. As part of this, blockquote's default styles are being simplified, and styled-quote is being created to house any complex styling requirements that might arise rather than putting a lot of stuff into the tag based CSS. Adjacent commits will be made to both ThemeBoilerplate and Blocks to match this new expectation.

To bring our multiple quote outputs into one standardised default output, which meets the HTML spec. As part of this, blockquote's default styles are being simplified, and styled-quote is being created to house any complex styling requirements that might arise rather than putting a lot of stuff into the tag based CSS. Adjacent commits will be made to both ThemeBoilerplate and Blocks to match this new expectation.
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Newnab Newnab merged commit 0d327a2 into main Jan 17, 2022
@Newnab Newnab deleted the chore/280-standardise-quote-html branch January 17, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants