Small patch to allow build on OS X #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged the tcgetattr/setattr bits but I am told that clock_gettime is present in MacOS X 10.12 SDK ? |
|
Fair enough. Unfortunately 10.12 doesn't support any of my hardware. Up to you how to proceed. |
|
Can you move the clock code so that it's in its own file + header and provides a fake clock_ function so the main code doesn't need to change except to include your compat header ? |
|
Yeah, sure, makes sense. I was wondering about doing that before.
…On 3 August 2017 at 14:18, EtchedPixels ***@***.***> wrote:
Can you move the clock code so that it's in its own file + header and
provides a fake clock_ function so the main code doesn't need to change
except to include your compat header ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADG-wdG7Yrh6jg0oV_ARfjOqnlTDz7Tks5sUcingaJpZM4OiyGU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This substitutes the use of clock_gettime for the Mach clock service. It also converts ioctl(0, TCSETS ...) and ioctl(0, TCGETS...) calls to tcsetattr and tcgetattr, which will build on Linux or OS X.