GH-170 Add PlaceHolderAPI, enchance FightTag class #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… who starts tag countdown for player.
CitralFlo
requested review from
Rollczi,
vLuckyyy,
P1otrulla,
imDMK and
ChudziudgiToJa
CitralFlo
changed the title
P1otrulla
reviewed
May 24, 2024
eternalcombat-api/src/main/java/com/eternalcode/combat/fight/FightTagPlaceholder.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java
Outdated
Show resolved
Hide resolved
eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java
Outdated
Show resolved
Hide resolved
Rollczi
reviewed
Jun 28, 2024
eternalcombat-api/src/main/java/com/eternalcode/combat/CombatCommand.java
Outdated
Show resolved
Hide resolved
eternalcombat-api/src/main/java/com/eternalcode/combat/CombatCommand.java
Outdated
Show resolved
Hide resolved
eternalcombat-api/src/main/java/com/eternalcode/combat/fight/FightTagPlaceholder.java
Outdated
Show resolved
Hide resolved
eternalcombat-api/src/main/java/com/eternalcode/combat/fight/FightTagPlaceholder.java
Outdated
Show resolved
Hide resolved
eternalcombat-api/src/main/java/com/eternalcode/combat/fight/FightManager.java
Show resolved
Hide resolved
Rollczi
approved these changes
Jun 29, 2024
VerniQ
approved these changes
Jun 30, 2024
vLuckyyy
approved these changes
Jul 1, 2024
...lcombat-api/src/main/java/com/eternalcode/combat/bridge/placeholder/FightTagPlaceholder.java
Outdated
Show resolved
Hide resolved
imDMK
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PlaceHolderAPI, create basic placeholders. Add tagger as a person who starts tag countdown for player.