Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken dependency #157

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix broken dependency #157

merged 1 commit into from
Jul 18, 2022

Conversation

kchojn
Copy link
Collaborator

@kchojn kchojn commented Jul 14, 2022

Updated requests-cache version. Pipenv could not handle the bad dependencies in this package!

@piotr-rudnik
Copy link
Contributor

Are you sure about this? If pipenv failes, that means package building would fail also. Anyway, pinning packages version is a good thing so let's do it.

@kchojn
Copy link
Collaborator Author

kchojn commented Jul 15, 2022

Are you sure about this? If pipenv failes, that means package building would fail also. Anyway, pinning packages version is a good thing so let's do it.

Yes, tested well. Previously there was *, and the new version was released at the end of June, where it contains a bad dependency on which pipenv crashes (Cattrs probably )
Let's make a new release on Monday, because I have some important changes.
I will also add a ga with package build testing.

@kchojn kchojn merged commit 107c04f into EthTx:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants