Sigantures/Semantics bug fixes #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-rudnik
requested changes
Oct 11, 2021
ethtx/decoders/decoder_service.py
Outdated
| "Semantics used in decoding %s: %s", tx_hash, ", ".join(used_semantics) | ||
| "Semantics used in decoding %s: %s", | ||
| tx_hash, | ||
| ", ".join(used_semantics) if isinstance(used_semantics, list) else "", |
There was a problem hiding this comment.
This can only be a list or None, if it's none, there could be an information about this
Comment on lines
103
to
115
| if MongoCollections.ADDRESSES not in self._db.list_collection_names(): | ||
| self._addresses = self._db[MongoCollections.ADDRESSES] | ||
|
|
||
| if MongoCollections.CONTRACTS not in self._db.list_collection_names(): | ||
| self._contracts = self._db[MongoCollections.CONTRACTS] | ||
|
|
||
| if MongoCollections.SIGNATURES not in self._db.list_collection_names(): | ||
| self._signatures = self._db[MongoCollections.SIGNATURES] | ||
| self._signatures.create_index( | ||
| [("signature_hash", "TEXT"), ("name", "TEXT")], | ||
| background=True, | ||
| unique=False, | ||
| ) |
There was a problem hiding this comment.
- Take list_collection_names and put it in variable, instead of calling it 3 times.
- Why are those variables not initialized when collections are not in db?
There was a problem hiding this comment.
and unique shouldn't be True?
There was a problem hiding this comment.
Refactored. You are right, unique=True. They are initialized when collections are not in db.
There was a problem hiding this comment.
Better, but still if collections are not in db, self._addresses self._contracts and self._signatures will be empty. Normally those collections would be created by mongo itself, here program will just fail if those are not created by user manually.
tmierzwa
approved these changes
Oct 11, 2021
piotr-rudnik
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__files for semanticssignaturecollection is now indexedblackcode