Add node switcher #68
Conversation
tests/providers/node/pool_test.py
Outdated
| @classmethod | ||
| def setup_class(cls): | ||
| cls.pool = NodeConnectionPool(nodes=MAINNET_CHAIN) |
There was a problem hiding this comment.
It would be better to create new pool for every test, just to make sure starting state for tests is always the same.
There was a problem hiding this comment.
Tests go from top to bottom, so I think it's not necessary to duplicate object creation, where the object is not changed and logic is simple.
There was a problem hiding this comment.
In no way test should be dependent on other tests, and there is no guarantee to run in order. There are at least 2 situations when this would be an obstacle, first one is when someone tries to make a single test pass, and instead of running this single test after implementing changes in code, he's forced to run whole class of tests. Second one is parallelism, with this approach we are losing part of functionalities from plugins like xdist for pytest, in short, we can't run every test in different process, we are limited to classes per process.
tests/providers/node/pool_test.py
Outdated
| @classmethod | ||
| def setup_class(cls): | ||
| cls.pool = NodeConnectionPool(nodes=MAINNET_CHAIN) |
There was a problem hiding this comment.
In no way test should be dependent on other tests, and there is no guarantee to run in order. There are at least 2 situations when this would be an obstacle, first one is when someone tries to make a single test pass, and instead of running this single test after implementing changes in code, he's forced to run whole class of tests. Second one is parallelism, with this approach we are losing part of functionalities from plugins like xdist for pytest, in short, we can't run every test in different process, we are limited to classes per process.
Web3ConnectionExceptiontoNodeConnectionExceptiontestsdirectory structure