Refactor ENS provider, catch more exceptions from 4byte.direcotry #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kchojn
commented
Oct 17, 2021
•
kchojn
commented
- Refactored ENS provider, each time a new ens object is taken
- Catch more exceptions from 4byte.directory (looks like the service is not always working properly)
- Added more logging
- Added more exceptions.
piotr-rudnik
requested changes
Oct 25, 2021
ethtx/providers/ens_provider.py
Outdated
Comment on lines
25
to
30
| def name(self, provider: Callable, address: Any): | ||
| ... | ||
|
|
||
| @abstractmethod | ||
| def address(self, name: Any): | ||
| def address(self, provider: Callable, name: Any): | ||
| ... |
There was a problem hiding this comment.
Types should not be Callable but Web3
There was a problem hiding this comment.
Its an abstract base class, all ens resolvers need some provider. Web3Ens got an exact type - Web3
There was a problem hiding this comment.
Callable is type that implements call method afaik, Web3 does not have it.
piotr-rudnik
reviewed
Nov 1, 2021
ethtx/providers/ens_provider.py
Outdated
Comment on lines
25
to
30
| def name(self, provider: Callable, address: Any): | ||
| ... | ||
|
|
||
| @abstractmethod | ||
| def address(self, name: Any): | ||
| def address(self, provider: Callable, name: Any): | ||
| ... |
There was a problem hiding this comment.
Callable is type that implements call method afaik, Web3 does not have it.
piotr-rudnik
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.