Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch invalid names #1138

Merged
merged 5 commits into from
Mar 31, 2023
Merged

fix: catch invalid names #1138

merged 5 commits into from
Mar 31, 2023

Conversation

olgakup
Copy link
Contributor

@olgakup olgakup commented Mar 22, 2023 •
edited

Describe your changes:

adds catch to ens name normalization

Fixes #issue: (if present)

page goes unresponsive when url gets entered into input field which supports ens resolution

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have removed hard coded strings
  • I have added entry to ./changelog
  • I have added pr label
  • I have commented my code, particularly in hard-to-understand areas

@olgakup olgakup added the bug label Mar 31, 2023
@olgakup olgakup merged commit eb0d702 into develop Mar 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/search-url branch March 31, 2023 18:38
@olgakup olgakup mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olgakup @mew-bot