Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/settings #1141

Merged
merged 21 commits into from
Apr 4, 2023
Merged

Feat/settings #1141

merged 21 commits into from
Apr 4, 2023

Conversation

olgakup
Copy link
Contributor

@olgakup olgakup commented Mar 27, 2023

Describe your changes:

Adds Settings View and Addresses' Names list and functionality.
Migrates theme change to settings menu.
Contains changes to the store:

  • deleting portfolio item will still keep it in address's names
  • checks if address is already saved before adding it again

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have removed hard coded strings
  • I have added entry to ./changelog
  • I have added pr label
  • I have commented my code, particularly in hard-to-understand areas

@olgakup olgakup marked this pull request as ready for review March 31, 2023 18:28
@olgakup olgakup added the feature new feature label Apr 1, 2023
@olgakup olgakup merged commit 0fec030 into develop Apr 4, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/settings branch April 4, 2023 22:31
@olgakup olgakup mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants