Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translation for txs detailed #1159

Merged
merged 7 commits into from
May 25, 2023
Merged

feat: translation for txs detailed #1159

merged 7 commits into from
May 25, 2023

Conversation

wolftec071018
Copy link
Collaborator

@wolftec071018 wolftec071018 commented May 19, 2023 •
edited

Describe your changes:

Translation of transaction details

Fixes #issue: (if present)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have removed hard coded strings
  • I have added entry to ./changelog
  • I have added pr label
  • I have commented my code, particularly in hard-to-understand areas

@wolftec071018 wolftec071018 added the feature new feature label May 19, 2023
olgakup
olgakup requested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@olgakup olgakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please merge recent version of develop branch. You will see that there are more tabs added to the page view.

v2/src/modules/txs/components/TabMore.vue Outdated Show resolved Hide resolved
v2/src/modules/txs/components/TabMore.vue Outdated Show resolved Hide resolved
v2/src/modules/txs/components/TabMore.vue Outdated Show resolved Hide resolved
v2/src/translations/en_US.json Outdated Show resolved Hide resolved
@olgakup olgakup changed the base branch from translation-settings to develop May 22, 2023 22:30
@olgakup olgakup merged commit f681412 into develop May 25, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the translation-txn-details branch May 25, 2023 22:21
@olgakup olgakup mentioned this pull request May 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgakup olgakup olgakup approved these changes

Assignees
No one assigned
Labels
feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolftec071018 @olgakup @mew-bot