Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci) replace npm install with npm run install:ci #18

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

benceHornyak
Copy link
Contributor

Proposed changes:

  • create a custom script for running npm ci
  • use that custom script in the CI

Ref #13

@benceHornyak benceHornyak changed the title feat(ci) replace npm instll with npm run install:ci feat(ci) replace npm install with npm run install:ci Jan 19, 2019
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Small fix and we’ll get this merged.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ethan-Arrowood
Copy link
Contributor

I’m away from my computer at the moment. Once I get back I’ll merge this 👍

@Ethan-Arrowood Ethan-Arrowood merged commit 93a58c1 into MatterhornDev:master Jan 19, 2019
@benceHornyak benceHornyak deleted the feat/ci branch January 22, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants