Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config_path for cron expressions #201

Closed
peterjaap opened this issue Nov 20, 2023 · 2 comments · Fixed by #203
Closed

Support config_path for cron expressions #201

peterjaap opened this issue Nov 20, 2023 · 2 comments · Fixed by #203

Comments

@peterjaap
Copy link

While working on #97, I discovered that this extension does not show the frequency for cron jobs that use a config_path field instead of a schedule field.

For example the currency_rates_update job;

image

It's crontab.xml looks like this;

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Cron:etc/crontab.xsd">
    <group id="default">
        <job name="currency_rates_update" instance="Magento\Directory\Model\Observer" method="scheduledUpdateCurrencyRates">
            <config_path>crontab/default/jobs/currency_rates_update/schedule/cron_expr</config_path>
        </job>
    </group>
</config>
@peterjaap
Copy link
Author

peterjaap commented Nov 20, 2023

Added here; #203

You can test this by setting the currency_rates_update cron expression through magerun2;

magerun2 config:store:set crontab/default/jobs/currency_rates_update/schedule/cron_expr "0 * * * *"
magerun2 cache:clear config

@fredden
Copy link
Collaborator

fredden commented Dec 28, 2023

This has been completed in #203, which landed in v2.1.6.

@fredden fredden closed this as completed Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants