Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for Magento 2.4 & PHP 7.4 #155

Merged
merged 5 commits into from Oct 11, 2020
Merged

Update tests for Magento 2.4 & PHP 7.4 #155

merged 5 commits into from Oct 11, 2020

Conversation

fredden
Copy link
Collaborator

@fredden fredden commented Oct 7, 2020

No description provided.

@fredden fredden marked this pull request as draft October 8, 2020 06:39
@fredden fredden marked this pull request as ready for review October 9, 2020 15:19
Ethan3600
Ethan3600 approved these changes Oct 11, 2020
View reviewed changes
Copy link
Owner

@Ethan3600 Ethan3600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredden LGTM! Going to merge

@Ethan3600 Ethan3600 merged commit a374e3b into Ethan3600:1.x Oct 11, 2020
@fredden fredden deleted the mage-2.4-support branch December 12, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan3600 Ethan3600 Ethan3600 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredden @Ethan3600