Add Mass Actions + Bug Fixes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're also removing inline editing. Primarily because it's an annoying interface in my opinion. If users want, they'll most likely make an issue asking to add it in
Before, it would only check for status that are pending and it would only check per group. Now it only cares about the expiration date
Some of these methods were built when we were usings the Queues api. We are no longer bound by that api so we can refactor
We don't want ot stop everything from running if one fails
This could be a dangerous process. Users should be aware of that
UiComponents support a filter API which makes loading schedules based on the request parameters a lot easier. We had to extend the Collection and explicitly set the $_idFieldName parameter because the collection never sets it upon instantiation for Cron Collections (bug?)
This will allow us to delete many rows in the database without opening and closing connections with the database. This will run one query, once and get the job done quickly
Originally, this was "the" timeline feature. It was rebranded as visualizer to avoid confusion. Personally, I don't think anyone cares about it. It adds little value and is just "eye candy." I will no longer be supporting this feature, but it will remain in the manager until further notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this branch was for just adding mass actions, but then it turned into a code UX refactor. The code is now more "consistent" and takes advantage of name spaces.
The following Mass actions are now supported on the dashboard:
Dispatch
Delete
I was going to include "schedule now" but it seems redundant since you can do that on the job configuration section.
The two mass actions can be somewhat dangerous since it operates on a more granular scale, especially the dispatch method. Dispatching many crons can cause Magento to crash! It should be used with caution
fixes issues #45 #21
Also, this PR adds a scaling feature for the timeline that will help zoom in and zoom out of the timeline.