Merge branch 'main' into fix/642

EthanThatOneKid · Nov 5, 2022 · 183d301 · 183d301
2 parents 6175dc6 + 22ae77d
commit 183d301
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/routes/(site)/about/officer-profile-list.svelte b/src/routes/(site)/about/officer-profile-list.svelte
@@ -24,9 +24,12 @@
    */
   function sortByTier(termCode: Term) {
     return (a: Officer, b: Officer) => {
-      const aTier = a.positions[termCode]!.tier;
-      const bTier = b.positions[termCode]!.tier;
-      return aTier - bTier;
+      const aPos = a.positions[termCode];
+      const bPos = b.positions[termCode];
+      if (!aPos || !bPos) {
+        throw new Error(`a or b has no position`);
+      }
+      return aPos.tier - bPos.tier;
     };
   }