Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail CI when PR is not formatted properly #161

Closed
EthanThatOneKid opened this issue Oct 27, 2021 · 1 comment
Closed

Fail CI when PR is not formatted properly #161

EthanThatOneKid opened this issue Oct 27, 2021 · 1 comment
Assignees
@EthanThatOneKid
Labels
enhancement New feature or request
Projects
🍂 Fall 2021
Milestone
v2.0 💫

Comments

@EthanThatOneKid
Copy link
Owner

What's your idea?

We want our build command to fail when a PR attempts to merge when the PR's code is not properly formatted. This way, only formatted code is guaranteed to enter the codebase.
@EthanThatOneKid EthanThatOneKid added the enhancement New feature or request label Oct 27, 2021
@EthanThatOneKid EthanThatOneKid self-assigned this Nov 9, 2021
@EthanThatOneKid EthanThatOneKid added this to To do in 🍂 Fall 2021 via automation Nov 9, 2021
@EthanThatOneKid EthanThatOneKid added this to the v2.0 💫 milestone Nov 9, 2021
@EthanThatOneKid
Copy link
Owner Author

Resolved by #192 and #199.

🍂 Fall 2021 automation moved this from To do to Done Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EthanThatOneKid EthanThatOneKid

Labels
enhancement New feature or request
Projects
🍂 Fall 2021
Done
Milestone
v2.0 💫
Development

No branches or pull requests
1 participant
@EthanThatOneKid