Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created check_website.yaml workflow and eliminated remaining lint errors #192

Merged
merged 3 commits into from Nov 6, 2021
Merged

Created check_website.yaml workflow and eliminated remaining lint errors #192

merged 3 commits into from Nov 6, 2021

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Nov 6, 2021 •
edited

  • Created the check_website.yaml workflow that will run on each PR.
  • Cleaned up all of the current errors, warnings, and hints that the npm run check command produces.

Intended to resolve #185 🎉

@vercel
Copy link

vercel bot commented Nov 6, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/VhorUzYWD6J94dTaYUAqtkBDQs4p
✅ Preview: https://acm-csuf-site-git-fix-185-ethanthatonekid.vercel.app

@EthanThatOneKid EthanThatOneKid mentioned this pull request Nov 6, 2021
Closed
@vercel vercel bot temporarily deployed to Preview November 6, 2021 02:10 Inactive
@EthanThatOneKid EthanThatOneKid mentioned this pull request Nov 6, 2021
Closed
2 tasks
@EthanThatOneKid EthanThatOneKid merged commit 2fa8f60 into main Nov 6, 2021
@EthanThatOneKid EthanThatOneKid mentioned this pull request Nov 9, 2021
Closed
@EthanThatOneKid EthanThatOneKid added developer experience Enhancement geared towards the devs devops Some operation must be executed enhancement New feature or request labels Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamondburned diamondburned diamondburned approved these changes

@anhduy1202 anhduy1202 Awaiting requested review from anhduy1202

Assignees
No one assigned
Labels
developer experience Enhancement geared towards the devs devops Some operation must be executed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up GitHub Action for Svelte and TypeScript linting
2 participants
@EthanThatOneKid @diamondburned