Fix shortlink resolution bug

[EthanThatOneKid]

Previously

The shortlink resolver wasn't working correctly. It would try to match invalid paths to shortlinks.

Now

The shortlink resolver is fixed! It correctly identifies shortlinks by looking at each segment (part separated by "/") within the path, from the beginning to the end of the string. So, now searching for "/colors" will find the correct shortlink instead of resolving incorrectly to "/c".

src/lib/server/links/resolve.ts

    let id = pathname.slice(1) as ID;
    while (id.length > 0 && !shortlinks[id]) {
-      id = id.slice(0, id.lastIndexOf('/')) as ID;
+      const slashIndex = id.lastIndexOf('/');
+      if (slashIndex === -1) {
+        break;
+      }
+
+      id = id.slice(0, slashIndex) as ID;
    }

    if (!shortlinks[id]) {

[netlify]

✅ Deploy Preview for acmcsuf ready!

Name	Link
🔨 Latest commit	edb6010
🔍 Latest deploy log	https://app.netlify.com/sites/acmcsuf/deploys/65f76b98661ecb00083285ba
😎 Deploy Preview	https://deploy-preview-1044--acmcsuf.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[karnikaavelumani]

Thank you for this PR! LGTM!

[EthanThatOneKid]

The specific test cases listed in #1019 (comment) are confirmed to be working as expected.