Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quiz Page #1059

Merged
merged 20 commits into from
May 3, 2024
Merged

Update Quiz Page #1059

merged 20 commits into from
May 3, 2024

Conversation

26samaahmed
Copy link
Collaborator

Fix #1052
Screenshot 2024-04-09 at 10 56 43 PM

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 59c76e1
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/66342c3d6ba93500073a6481
😎 Deploy Preview https://deploy-preview-1059--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks:

Color of button on results page looks weird in dark mode

image

Gaps between team tiles could be increased horizontally and vertically

image

Update results title to include "Quiz" e.g. "Quiz Results"

Add 10% to Open Source Software team results

@JustinStitt
Copy link
Collaborator

Your PR description says "Fix #1052" but #1052 mentions updating more than just the UI: We need to update the data along with doing a redesign to fit with the style of the rest of the website.

I think a bit more detail in your PR descriptions can help reviewers understand what is going on. With that being said, and with Ethan's review, you're on the right track 👍 🦖

@26samaahmed
Copy link
Collaborator Author

I have fixed the buttons on the results page as well as increase the gap between the team tile. I also noticed that the progress bar for some teams disappears on mobile so I increased the padding for the team tiles to be responsive.

Screenshot 2024-04-16 at 2 22 33 PM Screenshot 2024-04-16 at 2 30 30 PM

Screenshot 2024-04-16 at 2 21 38 PM Screenshot 2024-04-16 at 2 23 56 PM

@karnikaavelumani
Copy link
Collaborator

karnikaavelumani commented Apr 22, 2024

TODO

  • Choice boxes should be a set size
    image
  • Change the color of the choice boxes to be a darker color so the words pop out more (maybe it could be var(--acm-blue) while the buttons are var(--acm-bluer)
  • Remove glow effect and replace with a solid border on hover
    image
  • Remove the general team, marketing team, special events team, and nodebuds team in the final results
    image

@26samaahmed
Copy link
Collaborator Author

For removing general, marketing, nodebuds, and special events team tiles from quiz results, the only way I was able to remove them is by deleting them from the teams.json since that's where we're getting the data from. Is there another way to remove them without affecting the rest of the website or modifying the teams.json file? @karnikaavelumani @EthanThatOneKid

@26samaahmed
Copy link
Collaborator Author

26samaahmed commented Apr 30, 2024

I removed the glow effect on hover and replaced it with a border color. I also changed the background color to be more readable and made the height fixed.

Screenshot 2024-04-29 230433

Screenshot 2024-04-29 230523

Screenshot 2024-04-29 231948

requirements.txt Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python moment

Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karnikaavelumani karnikaavelumani enabled auto-merge (squash) May 3, 2024 00:11
@karnikaavelumani karnikaavelumani enabled auto-merge (squash) May 3, 2024 00:15
@EthanThatOneKid EthanThatOneKid merged commit 25eb546 into main May 3, 2024
5 checks passed
@EthanThatOneKid EthanThatOneKid deleted the fix/1052 branch May 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the /quiz UI
4 participants