Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center NodeBuds logo animation on mobile #1060

Merged
merged 3 commits into from
Apr 14, 2024
Merged

Center NodeBuds logo animation on mobile #1060

merged 3 commits into from
Apr 14, 2024

Conversation

26samaahmed
Copy link
Collaborator

Fix #985

Screen.Recording.2024-04-09.at.11.19.59.PM.mov

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit 66160ff
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/661c3fc8ad5fb10008c0d538
😎 Deploy Preview https://deploy-preview-1060--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JustinStitt
Copy link
Collaborator

Hi, I do not notice the same issue reported in #985 for mobile -- for me, the logo is pretty darn well centered on mobile.

With that being said, I think you're on the right track with your change; as far as making this animation look better.

Could we try reducing the side-to-side movement of this animation and have it spend more time in the center?

Here's an example (sorry the gif doesn't loop perfectly):

This was created with:

  .nodebuds-animation img {
    ...
    animation-timing-function: cubic-bezier(0, 0, 0, 0);
    ...
  }

  @keyframes slide {
    0% {
      left: -60px;
    }

    33% {
      left: -5px;
    }

    50% {
      left: 0;
    }

    66% {
      left: 5px;
    }

    100% {
      left: 60px;
    }
  }

@26samaahmed
Copy link
Collaborator Author

Hii, I updated the animation as suggested by reducing the side to side movement. Thank you for the suggestion, it looks better now.

Screen.Recording.2024-04-12.at.8.08.59.PM.mov

Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really clean! Nice work Sama ❤️

@karnikaavelumani
Copy link
Collaborator

Make sure to update the branch!

@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) April 14, 2024 20:47
@EthanThatOneKid EthanThatOneKid merged commit 6b14aef into main Apr 14, 2024
6 checks passed
@EthanThatOneKid EthanThatOneKid deleted the fix/985 branch April 14, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center the nodebuds logo animation on mobile
4 participants