-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Center NodeBuds logo animation on mobile #1060
Conversation
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi, I do not notice the same issue reported in #985 for mobile -- for me, the logo is pretty darn well centered on mobile. With that being said, I think you're on the right track with your change; as far as making this animation look better. Could we try reducing the side-to-side movement of this animation and have it spend more time in the center? Here's an example (sorry the gif doesn't loop perfectly): This was created with: .nodebuds-animation img {
...
animation-timing-function: cubic-bezier(0, 0, 0, 0);
...
}
@keyframes slide {
0% {
left: -60px;
}
33% {
left: -5px;
}
50% {
left: 0;
}
66% {
left: 5px;
}
100% {
left: 60px;
}
} |
Hii, I updated the animation as suggested by reducing the side to side movement. Thank you for the suggestion, it looks better now. Screen.Recording.2024-04-12.at.8.08.59.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really clean! Nice work Sama ❤️
Make sure to update the branch! |
Fix #985
Screen.Recording.2024-04-09.at.11.19.59.PM.mov