Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add teams re-direct to homepage #1076

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Add teams re-direct to homepage #1076

merged 5 commits into from
Apr 23, 2024

Conversation

JOwen-ster
Copy link
Contributor

@JOwen-ster JOwen-ster commented Apr 23, 2024 •
edited

@EthanThatOneKid @karnikaavelumani

  • Added team icon re-direct on homepage
  • Added OSS team to homepage
  • Added scale hover effect to team icons on homepage

image

Fix #1043

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited

👷 Deploy request for acmcsuf pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1846924

EthanThatOneKid
EthanThatOneKid requested changes Apr 23, 2024
View reviewed changes
src/routes/(site)/teams.svelte Outdated Show resolved Hide resolved
@JOwen-ster @EthanThatOneKid
Update src/routes/(site)/teams.svelte
dfd3b25 
Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
NateGries1
NateGries1 approved these changes Apr 23, 2024
View reviewed changes
Copy link

@NateGries1 NateGries1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game is game.

@26samaahmed
Copy link
Collaborator

Looks very nice!

EthanThatOneKid
EthanThatOneKid approved these changes Apr 23, 2024
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for optimizing the navigation experience to each team from the landing page.

karnikaavelumani
karnikaavelumani approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JOwen-ster
Copy link
Contributor Author

First contribution to site yay!

karnikaavelumani
karnikaavelumani approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work and first pr!

@karnikaavelumani karnikaavelumani merged commit a8ea1f6 into EthanThatOneKid:main Apr 23, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani approved these changes

@NateGries1 NateGries1 Awaiting requested review from NateGries1

@EthanThatOneKid EthanThatOneKid Awaiting requested review from EthanThatOneKid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hover effect and link to teams page
5 participants
@JOwen-ster @26samaahmed @EthanThatOneKid @karnikaavelumani @NateGries1