Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav design tweaks #435

Merged
18 commits merged into from Apr 17, 2022
Merged

Nav design tweaks #435

18 commits merged into from Apr 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2022 •
edited by ghost

  • Reverted to right-leaning nav for desktop
  • h3 properly clamps for 280px vw
  • Horizontal padding on mobile changed to 16px
  • Added 'chapter' to badge
  • added 'at' to logo wording
  • changed general badge alt tag

hhoang91 and others added 3 commits April 15, 2022 17:29
@hhoang91
fixed the logo path
581077f
@EthanThatOneKid
Merge branch 'main' into fix/429
084c196
Design tweaks
028e224 
- Reverted to right-leaning nav for desktop
- h3 properly clamps for 280px vw
- Horizontal padding on mobile changed to 16px
- changed general badge alt tag
@ghost ghost added this to the v3.0 🌞 milestone Apr 17, 2022
@ghost ghost requested a review from EthanThatOneKid April 17, 2022 18:45
@vercel
Copy link

vercel bot commented Apr 17, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ethanthatonekid/acm-csuf-site/Ebo5PLbab4p62NbdbvX5o8cSZB96
✅ Preview: https://acm-csuf-site-git-nav-tweaks-ethanthatonekid.vercel.app

@vercel vercel bot temporarily deployed to Preview April 17, 2022 18:45 Inactive
ACM Chapter Branding Compliance
f510a97 
- Added 'chapter' to badge
- added 'at' to logo wording
@vercel vercel bot temporarily deployed to Preview April 17, 2022 18:54 Inactive
@ghost ghost changed the title Design tweaks Nav Design tweaks Apr 17, 2022
@ghost ghost changed the title Nav Design tweaks Nav design tweaks Apr 17, 2022
@vercel vercel bot temporarily deployed to Preview April 17, 2022 18:55 Inactive
mikeploythai added 6 commits April 17, 2022 12:02
Footer tweaks
c6c49ad 
- Removed camel case branding
- Removed horizontal padding to make footer not break on 280px vw
Index / refactored hero
9453e9e 
- Dynamic scaling of img and h1 container
- container padding lowered to 16px
Index / refactored paths
d1fe28f 
- Reworded path description and header
- lowered container padding to 16px
- Removed 'acm' from path names to comply with ACM guidelines
- Path name changes color on hover
Nav / Refactored CTA section
09d82ae 
- Reworded descriptions
- Lowered container padding to 16px
Index / refactored why join section
3bfd477 
- Reworded description
- Dynamic scaling for img
- Lowered container padding to 16px
ACM button refactor
0348b1a 
- Background changes on hover to blue or light gray depending on theme
- Larger text
mikeploythai added 2 commits April 17, 2022 14:19
Extra tweaks
5eb3fcd 
- Decreased all container paddings to 8px
- made why join img scale smaller
Minimum padding moved to 900px breakpoint
6faa39e
EthanThatOneKid
EthanThatOneKid approved these changes Apr 17, 2022
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel vercel bot temporarily deployed to Preview April 17, 2022 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview April 17, 2022 22:15 Inactive
@jaasonw jaasonw linked an issue Apr 17, 2022 that may be closed by this pull request
The ACMCSUF Logo disappears when navigating to a URL with multi-level subdirectory #429
Closed
jaasonw
jaasonw suggested changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@jaasonw jaasonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you run npm run all and then commit the result to fix the formatting check

@ghost
Copy link
Author

ghost commented Apr 17, 2022 •
edited by ghost

can you run npm run all and then commit the result to fix the formatting check

i did lol

EDIT: oh wait did it on the wrong branch lmao

@jaasonw
Copy link
Contributor

jaasonw commented Apr 17, 2022

can you run npm run all and then commit the result to fix the formatting check

i did lol

image

run it and commit this file

@ghost
Copy link
Author

ghost commented Apr 17, 2022

can you run npm run all and then commit the result to fix the formatting check

i did lol

image

run it and commit this file

Read my edit lmfao

@jaasonw
Copy link
Contributor

jaasonw commented Apr 17, 2022

can you run npm run all and then commit the result to fix the formatting check

i did lol

image
run it and commit this file

Read my edit lmfao

nice1

@vercel vercel bot temporarily deployed to Preview April 17, 2022 22:26 Inactive
@ghost ghost merged commit d51c766 into main Apr 17, 2022
@ghost ghost deleted the nav-tweaks branch April 17, 2022 22:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0 🌞
Development

Successfully merging this pull request may close these issues.

The ACMCSUF Logo disappears when navigating to a URL with multi-level subdirectory
3 participants
@jaasonw @EthanThatOneKid @hhoang91