Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Display TBD if location is empty or null #479

Merged
merged 16 commits into from Jun 5, 2022

Conversation

charliettaylor
Copy link
Contributor

@charliettaylor charliettaylor commented May 22, 2022

event-item

  • checks if location is null or empty, displaying TBD if it is null, empty, or white space

hopefully small and easy fix :^)

Resolves #416

@vercel
Copy link

vercel bot commented May 22, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @EthanThatOneKid on Vercel.

@EthanThatOneKid first needs to authorize it.

@vercel
Copy link

vercel bot commented May 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Jun 5, 2022 at 5:31AM (UTC)

@vercel vercel bot temporarily deployed to Preview May 22, 2022 17:51 Inactive
@karnikaavelumani
Copy link
Collaborator

What an absolute king taking into consideration all edge cases and treating it like a leetcode problem

src/lib/ical/utils.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 27, 2022 09:06 Inactive
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking cool so far @Peekoe 😎

src/lib/components/events/event-item.svelte Outdated Show resolved Hide resolved
src/lib/ical/utils.ts Outdated Show resolved Hide resolved
src/lib/ical/parse.test.ts Outdated Show resolved Hide resolved
Co-authored-by: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
@charliettaylor charliettaylor dismissed jaasonw’s stale review May 30, 2022 04:44

Changes have been made

@charliettaylor charliettaylor merged commit e571135 into EthanThatOneKid:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I feel like default location should no longer be "Hosted on Discord"
4 participants