Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll forward #629 #648

Merged
merged 10 commits into from Oct 31, 2022
Merged

Roll forward #629 #648

merged 10 commits into from Oct 31, 2022

Conversation

EthanThatOneKid
Copy link
Owner

@EthanThatOneKid EthanThatOneKid commented Oct 31, 2022 •
edited

PR #629 introduced a regression by ignoring the changes made in #630. This PR reintroduces the changes from #630.

See: https://github.com/EthanThatOneKid/acmcsuf.com/blob/2912a4122b70da872c4425035e6ad11e2f42327c/src/routes/%2Blayout.svelte

jaasonw and others added 9 commits October 22, 2022 23:25
@jaasonw
check for process.env.VERCEL_ANALYTICS_ID
cf94ffa
@EthanThatOneKid
Merge branch 'main' into check_anal_id
b24bc8e
@EthanThatOneKid
Make public prefix empty, use dynamic public env
ee8622e 
- Refactored analytics library: factored out `send.ts` into `vitals.ts`.
- Added env variables to pass `website_check.yaml` workflow.

Addresses <#630 (comment)>.

Thanks @jaasonw for kicking off this PR :)
@EthanThatOneKid
Make public prefix empty, use dynamic public env
7e4842f 
- Refactored analytics library: factored out `send.ts` into `vitals.ts`.
- Added env variables to pass `website_check.yaml` workflow.

Addresses <#630 (comment)>.

Thanks @jaasonw for kicking off this PR :)
@EthanThatOneKid
Merge branch 'check_anal_id' of https://github.com/EthanThatOneKid/ac…
ece52d5 
…mcsuf.com into check_anal_id
@EthanThatOneKid
Merge branch 'check_anal_id' of https://github.com/EthanThatOneKid/ac…
30d1b93 
…mcsuf.com into check_anal_id
@EthanThatOneKid
Merge branch 'check_anal_id' of https://github.com/EthanThatOneKid/ac…
b49fc22 
…mcsuf.com into check_anal_id
@EthanThatOneKid
Merge branch 'check_anal_id' of https://github.com/EthanThatOneKid/ac…
f9cfc41 
…mcsuf.com into check_anal_id
@jaasonw
Merge branch 'main' into check_anal_id
df8e4c1
@EthanThatOneKid EthanThatOneKid added bugfix A PR that fixes a bug HIGH PRIORITY High priority issue, should be addressed ASAP labels Oct 31, 2022
@EthanThatOneKid EthanThatOneKid self-assigned this Oct 31, 2022
@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
acm-csuf-site ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 4:14AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 31, 2022 04:14 Inactive
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review October 31, 2022 04:16
@EthanThatOneKid EthanThatOneKid enabled auto-merge (squash) October 31, 2022 04:17
karnikaavelumani
karnikaavelumani approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many changes here! Looks good to me though.

@EthanThatOneKid EthanThatOneKid merged commit c13ab41 into main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani approved these changes

Assignees

@EthanThatOneKid EthanThatOneKid

Labels
bugfix A PR that fixes a bug HIGH PRIORITY High priority issue, should be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EthanThatOneKid @karnikaavelumani @jaasonw