Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deployment providers from Vercel to Netlify 馃帀 #700

Merged
merged 14 commits into from Nov 13, 2022
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions .env.example
Expand Up @@ -3,10 +3,5 @@ DEBUG_FLAG_ENABLED=1
GH_DISCUSSION_CATEGORY_ID="DIC_kwDOE7ysSc4CAC0o"
GH_ACCESS_TOKEN="馃挅"

# The Analytics ID is provided when your app builds on Vercel.
# It is accessed at runtime via svelte.config.js preprocessing.
# If a value is not provided, analytics are ignored.
VERCEL_ANALYTICS_ID=""

GCAL_API_KEY=""
GCAL_ID=""
GCAL_ID=""
2 changes: 1 addition & 1 deletion .gitignore
Expand Up @@ -4,7 +4,7 @@ node_modules
/.svelte-kit
/package
.env
.env.*
!.env.example
/coverage
.playwright_output
.netlify
2 changes: 0 additions & 2 deletions GETTING_STARTED.md
Expand Up @@ -4,7 +4,6 @@
1. Install [Git](https://git-scm.com/downloads)
- If you are not comfortable with the Git command line tool, you may use GitHub Desktop (<https://desktop.github.com/>). Take a look at <https://acmcsuf.com/1st/> if this is your first time contributing to an open source project.
1. Create a fork of [acmcsuf.com](https://github.com/EthanThatOneKid/acmcsuf.com), similar to <https://github.com/jaasonw/acmcsuf.com>
1. Create an account on [Vercel](https://vercel.com/) and create a new project linked to the fork you just created, similar to <https://acmcsuf-wayson.vercel.app/>
1. Create an [access token](https://scribehow.com/shared/Generating_a_personal_access_token__eMf0UJYaS5OcGrO_lJTpGg)
1. Follow [these instructions](https://github.com/EthanThatOneKid/acmcsuf.com/blob/main/CONTRIBUTING.md#setting-up-your-env-file) to add it to your dev environment

Expand All @@ -22,7 +21,6 @@
1. Whenever applicable (it鈥檚 not in this case), write unit tests for any new functions or components you create
1. Once you鈥檙e satisfied your changes, you **MUST** use `npm run all` to run all tests, lints, and formatting necessary for a release build, otherwise the automated build test will fail
1. Commit and push your changes
1. Go to your Vercel dashboard and verify that a preview deployment was pushed, similar to <https://acmcsuf-wayson-rbe1c3cul-jaasonw.vercel.app/>

## Submitting a pull request for review

Expand Down
11 changes: 6 additions & 5 deletions README.md
Expand Up @@ -4,7 +4,7 @@

[![Website Check](https://github.com/EthanThatOneKid/acmcsuf.com/actions/workflows/check_website.yaml/badge.svg)](https://github.com/EthanThatOneKid/acmcsuf.com/actions/workflows/check_website.yaml)

## Develop [馃懇鈥嶐煉籡[figma_design]
## Develop [馃懇鈥嶐煉籡[netlify_dashboard]

> 馃挕 This project runs on Node.js; [install the latest long-term support version][node_download].

Expand All @@ -18,8 +18,10 @@ For a more detailed overview of this repository's structure, feel free to review

## Deployment 馃殌

Whenever a push is made to the main branch, Vercel builds the site, tests it, and if there are no errors, it will deploy a preview site.
Once an admin approves the preview site, it gets promoted to production.
[![Netlify Status](https://api.netlify.com/api/v1/badges/ee624373-9c84-4f33-a5db-daa69d18ae6e/deploy-status)](https://app.netlify.com/sites/acmcsuf/deploys)

Whenever a push is made to the main branch, Netlify builds the site, tests it, and if there are no errors, it will deploy a preview site.
Once all checks have been passed, the preview site gets promoted to production.

---

Expand All @@ -30,7 +32,6 @@ Maintained with 馃挅 by [**acmcsuf.com hub**][team_doc]
[demo_url]: https://acmcsuf.com/
[acm_officers]: https://acmcsuf.com/about/
[webmaster_url]: https://github.com/EthanThatOneKid/
[figma_design]: https://www.figma.com/file/9cvuO69WgNGuCjf2JGDPfq/ACM-Website-Mockup---Mike-Ploythai?node-id=1%3A26
[dev_server]: http://localhost:3000/
[vercel_dashboard]: https://vercel.com/ethanthatonekid/acm-csuf-site
[netlify_dashboard]: https://app.netlify.com/sites/acmcsuf
[team_doc]: https://docs.google.com/document/d/11GoIBTAAnIOgmWuG1TsgXUE3MMkweQ8V6bB9TbrY0Hs/edit?usp=sharing
10 changes: 10 additions & 0 deletions netlify.toml
@@ -0,0 +1,10 @@
[build]
command = "npm run build"
functions = "functions"
publish = "build"

[dev]
command = "npm run dev"

[functions]
directory = "netlify/functions"