Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /wave2 board applications #861

Merged
merged 5 commits into from May 22, 2023
Merged

Create /wave2 board applications #861

merged 5 commits into from May 22, 2023

Conversation

karnikaavelumani
Copy link
Collaborator

See title.

Fix #860.

- Remove /s23positions
- Update board tier list
- Add new positions
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit ec53f8e
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/646bbedeead3420008d54c7d
😎 Deploy Preview https://deploy-preview-861--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wave2 looks very good to me so far! I left a couple comments for you to take a look at.

src/lib/public/board/data/tiers.json Outdated Show resolved Hide resolved
src/routes/(site)/wave2/+page.svelte Outdated Show resolved Hide resolved
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤯

@EthanThatOneKid EthanThatOneKid merged commit e18b973 into main May 22, 2023
12 checks passed
@karnikaavelumani karnikaavelumani deleted the fix/860 branch May 22, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create /wave2 board applications
2 participants