Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create description component #934

Merged
merged 3 commits into from Oct 18, 2023
Merged

Create description component #934

merged 3 commits into from Oct 18, 2023

Conversation

kalmk
Copy link
Collaborator

@kalmk kalmk commented Oct 11, 2023

image

Fix #924.

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited

✅ Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit b2222ab
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/652f5be7d3ed1c0008e6dc6d
😎 Deploy Preview https://deploy-preview-934--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EthanThatOneKid
EthanThatOneKid approved these changes Oct 12, 2023
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic.

Everything seems to be in order: the screenshots and Netlify preview look good, the code is clean, and all the checks have passed. 👍

If any adjustments are needed as we continue developing the 6.0 homepage, we'll create new issues for them.

@karnikaavelumani karnikaavelumani merged commit b568606 into main Oct 18, 2023
6 checks passed
@karnikaavelumani karnikaavelumani deleted the fix/924 branch October 18, 2023 04:19
@karnikaavelumani
Copy link
Collaborator

Merging into main!

Thank you @juyeongk365 for this PR. Whenever you get the notification if it's approved, feel free to squash and merge. I did it for you this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

@karnikaavelumani karnikaavelumani Awaiting requested review from karnikaavelumani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Desc component
3 participants
@kalmk @karnikaavelumani @EthanThatOneKid