Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Update/Penalty System #2

Merged
merged 3 commits into from
Jan 17, 2019
Merged

Security Update/Penalty System #2

merged 3 commits into from
Jan 17, 2019

Conversation

Dev-JamesR
Copy link
Contributor

@Dev-JamesR Dev-JamesR commented Jan 15, 2019

Simplified penalty system based on PR by cc:@hackmod (EthersocialNetwork/go-ethereum#1)

Originally based on the PIRLGuard system developed and deployed by the PIRL Team (https://git.pirl.io/)

Also See:
Horizen(ZenCash) System: https://www.horizen.global/assets/files/A-Penalty-System-for-Delayed-Block-Submission-by-Horizen.pdf
51% Attack Mitigation Penalty System by Horizen - https://www.youtube.com/watch?v=E99wpSZs6iM

@masterdubs
Copy link

Be sure to keep the chain sorting ( that was removed in your code ). If you remove it, you can have timing errors and corrupt your chain.

@hackmod
Copy link
Contributor

hackmod commented Jan 15, 2019

Be sure to keep the chain sorting ( that was removed in your code ). If you remove it, you can have timing errors and corrupt your chain.

Please see
https://github.com/ethereum/go-ethereum/blob/master/core/blockchain.go#L737-L744

at that points, chain blocks are already sorted.

Copy link
Contributor

@Primate411 Primate411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment tweaks.

core/penaltysystem.go Outdated Show resolved Hide resolved
core/penaltysystem.go Outdated Show resolved Hide resolved
core/penaltysystem.go Outdated Show resolved Hide resolved
core/penaltysystem.go Outdated Show resolved Hide resolved
Co-Authored-By: E1Code <39209383+E1Code@users.noreply.github.com>
@Dev-JamesR Dev-JamesR merged commit af83e80 into master Jan 17, 2019
fallengravity added a commit that referenced this pull request Mar 22, 2020
fractalyse added a commit to fractalyse/Ether1 that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants