Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform Component Tech Debt #7509

Closed
2 tasks done
HexaField opened this issue Jan 27, 2023 · 2 comments · Fixed by #7719
Closed
2 tasks done

Transform Component Tech Debt #7509

HexaField opened this issue Jan 27, 2023 · 2 comments · Fixed by #7719
Assignees
@HexaField

Comments

@HexaField
Copy link
Member

HexaField commented Jan 27, 2023 •
edited
Loading

  • Migrate TransformComponent & LocalTransformComponent to new component definition
  • Removing a TransformComponent should remove it from dirtyEntities list. We should add this to the onRemove call for the TransformComponent once it is migrated to the new component definition
@AidanCaruso
Copy link
Member

What is the priority on migrating the transform component to the new definition? I can work on drafting that if necessary as well.

@HexaField
Copy link
Member Author

What is the priority on migrating the transform component to the new definition? I can work on drafting that if necessary as well.

That would be great!

@HexaField HexaField changed the title Removing a TransformComponent should remove it from dirtyEntities list Transform Component Tech Debt Jan 30, 2023
@HexaField HexaField assigned HexaField and unassigned AidanCaruso Mar 10, 2023
@HexaField HexaField mentioned this issue Mar 12, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HexaField HexaField

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated createMappedComponent API EtherealEngine/etherealengine
2 participants
@HexaField @AidanCaruso