Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated createMappedComponent API #7719

Merged
merged 10 commits into from
Mar 12, 2023
Merged

Remove deprecated createMappedComponent API #7719

merged 10 commits into from
Mar 12, 2023

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Mar 9, 2023 •
edited

Summary

  • Replaces all usage of createMappedComponent with defineComponent
  • Replaces some components with hyperflux state, as they are only ever used on one entity

References

closes #7509

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@HexaField HexaField marked this pull request as ready for review March 12, 2023 03:05
@HexaField HexaField requested a review from speigg March 12, 2023 04:03
@HexaField HexaField disabled auto-merge March 12, 2023 23:47
@HexaField HexaField merged commit ea205b7 into dev Mar 12, 2023
@HexaField HexaField deleted the remove-deprecated-createMappedComponent-API branch March 12, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speigg speigg Awaiting requested review from speigg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transform Component Tech Debt
1 participant
@HexaField