-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant Action/Receptor pattern for state services #8305
Milestone
Comments
This was referenced Jul 20, 2023
This was referenced Jul 24, 2023
This was referenced Aug 8, 2023
This was referenced Sep 20, 2023
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Across the whole client, we have all these State/Receptor/Service/Action patterns, they need to be refactored to just State/Service
The idea here originally, was that a service function is called, which dispatches an action, that a receptor receives, and the state mutates. We wanted to control exactly when & how state was updated, but in practice, we only need this for networked actions (of which none of these client ones are, only ones with a specified
$topic
field are networked)So we can simplify this a LOT by just mutating state directly inside the service. This should make a lot of code easier to read, as well as spam chat a whole lot less.
becomes
The text was updated successfully, but these errors were encountered: