Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 6b20990
This pull request refactors and simplifies the state management and notification handling logic in various files across the client, editor, engine, and instance server packages. It removes unused and deprecated code, reduces unnecessary dependencies and re-renders, and improves code readability and performance. It also adds some state tracking and queueing features to the
SpectatorComponent
and theSceneLoadingSystem
respectively.References
closes #8305
Explanation
🤖 Generated by Copilot at 6b20990
NotificationAction
class and replaced notification actions with direct mutations ofsnackbar
state usingNotificationState
(link, link, link, link, link, link, link)EngineActions
and replaced engine actions with direct mutations ofisEngineInitialized
,sceneLoaded
, andspectating
states usingEngineState
andgetMutableState
(link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)isTeleporting
state fromEngineState
and moved it toPortalState
asactivePortalEntity
state to track the current portal entity (link, link, link, link)defineActionQueue
toPortalSystem
andSceneLoadingSystem
to handlesceneLoaded
actions and setsceneLoading
andsceneLoaded
states accordingly (link, link, link)AudioEffectPlayer
,matches
, anddispatchAction
from various files (link, link, link, link, link)🤖 Generated by Copilot at 6b20990
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist