-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR-2102 Material/Plugin Parameters #10180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanCaruso
requested review from
aditya-mitra,
speigg,
MichaelEstes and
dinomut1
May 22, 2024 17:03
SamMazerIR
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything seems functional, updated to useMutableState and fixed orbitCameraSystem refocus bug to properly refresh material preview panel
MbfloydIR
added a commit
that referenced
this pull request
May 24, 2024
* dev: (63 commits) hotfix vrm0 data not being where we expect it (#10236) Update tween.js version (#10241) Added ProjectPermissionDatabaseType physics bug fix (#10221) updated the background to use the color with when in wireframe render mode (#10231) vrm expressionmanager was being thrown away it is actually needed for viseme support to work (#10230) IR-1887-Asset-Preview-breaking-if-you-click-gltf-that-is-in-the-scene (#10208) query function fix (#10229) IR-2102 Material/Plugin Parameters (#10180) Fixed webcam light not turning off when camera paused. (#10224) Made client's server.js not bound to a specific host (#10223) Update FeathersHooks.tsx (#10228) Updated app name feat(setup): update logo and components props (#10204) Changes for feature flag schema to be string enum (#10225) Cleaned location hooks (#10216) Ir 1652 interactable input refactor (#10219) IR-2018 Refactor the Select component to disable search functionality for the dropdown only (#10206) refactor: Update Primus initialization to include pathname in server URL (#10205) Move physics enter/exit back to reactors (#10193) ... # Conflicts: # packages/editor/src/components/element/ElementList.tsx # packages/editor/src/components/properties/PostProcessingSettingsEditor.tsx # packages/engine/src/scene/SceneModule.ts # packages/spatial/src/renderer/components/PostProcessingComponent.tsx # packages/spatial/src/renderer/functions/configureEffectComposer.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds basic autogenerated parameter controls for plugin uniforms
Subtasks Checklist
Breaking Changes
References
closes the following:
https://tsu.atlassian.net/browse/IR-2111
https://tsu.atlassian.net/browse/IR-2102
QA Steps