Optimized publishing duplication #10220
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
|
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
|
…into optimized-publishing-duplication
…into optimized-publishing-duplication
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: root.
|
| const { sceneAssetID, projectName, sceneName, scenePath } = getState(EditorState) | ||
|
|
||
| if (projectName && sceneName && scenePath) { | ||
| const sceneQuery = useFind(assetPath, { query: { assetURL: scenePath ?? '' } }).data |
There was a problem hiding this comment.
This throws an invalid hook call. Must use useFind in a reactive context
| await saveSceneGLTF(sceneAssetID, projectName, sceneName + '-optimized', abortController.signal) | ||
| } | ||
|
|
||
| setCurrentEditorScene(sceneURL, sceneQuery[0].id! as EntityUUID) |
There was a problem hiding this comment.
This sets the current editor scene to the same scene it is currently in. Need to set current scene to the newly created copy
|
|
||
| setCurrentEditorScene(sceneURL, sceneQuery[0].id! as EntityUUID) | ||
| } | ||
|
|
There was a problem hiding this comment.
Everything after this point needs to wait for the scene change to complete and the new scene to finish loading. Use a useEffect and wait on the root scene entity to complete loading before proceeding with mesh baking
| await saveSceneGLTF(sceneAssetID, projectName, sceneName + '-optimized', abortController.signal) | ||
| } | ||
|
|
||
| setCurrentEditorScene(sceneURL, sceneQuery[0].id! as EntityUUID) |
There was a problem hiding this comment.
Also, this needs to be in the "bake" conditional as well, because if we're not baking we have no need to change editor scene
|
|
||
| // TODO: In duplicated scene, perform mesh baking to de-reference all models in the scene (saving scene as GLTF & fuse/compress scenes) | ||
| // TODO: Publish the duplicated scene | ||
|
|
There was a problem hiding this comment.
Here is where the "bake" conditional should end
|
|
||
| if (validateForm(state.value, state.formErrors.value)) { |
There was a problem hiding this comment.
Don't delete the validateForm function, this removes notifications about incorrectly entered fields
Summary
Scene duplication added on publish.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps