Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate Space Refactor + Separate Physics World Per Scene #10441

Merged
merged 75 commits into from
Jul 24, 2024

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Jun 22, 2024

Summary

  • Pass physicsWorld into all physics functions
  • Rename SceneComponent “children” field to “scenes”
  • Separate physics world for each auto generated scene component
  • Change XR spaces
  • Scale scenes rather than camera

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@HexaField HexaField changed the title Separate physics world per scene Coordinate Space Refactor + Separate Physics World Per Scene Jun 23, 2024
@MichaelEstes
Copy link
Contributor

I can't load into sky-station without falling through the ground, every other location works though so I'm not sure if that's an issue with how it's set up. Also occasionally I can't move the avatar after loading into a location. Everything else looks good

@HexaField
Copy link
Member Author

I can't load into sky-station without falling through the ground, every other location works though so I'm not sure if that's an issue with how it's set up. Also occasionally I can't move the avatar after loading into a location. Everything else looks good

Urgh :(
Screenshot from 2024-07-24 09-28-39

@HexaField
Copy link
Member Author

I have no idea what's going on. The transforms are all correct, but the rigidbodies themselves seem to be somehow not syncing? No idea how/when this regressed.

@HexaField
Copy link
Member Author

I can't load into sky-station without falling through the ground, every other location works though so I'm not sure if that's an issue with how it's set up. Also occasionally I can't move the avatar after loading into a location. Everything else looks good

Fixed. Came down to use not using the correct reference space in updating collider pose from transforms, and updating transforms from rigidbody ef649bb

Copy link
Member

@AidanCaruso AidanCaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested colliders of multiple scenes loaded together along with webxr.

@HexaField HexaField enabled auto-merge July 24, 2024 22:39
@HexaField HexaField added this pull request to the merge queue Jul 24, 2024
Merged via the queue into dev with commit e7868ba Jul 24, 2024
25 checks passed
@HexaField HexaField deleted the ir-1827-separate-physics-world-per-scene branch July 24, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants