refetch scenes after new scene on toolbar #10520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYBIOTE
approved these changes
Jul 5, 2024
speigg
previously requested changes
Jul 7, 2024
| @@ -56,18 +56,18 @@ export default function ScenesPanel() { | |||
| getMutableState(EditorState).scenePath.set(scene.key) | |||
| } | |||
|
|
|||
| useRealtime(fileBrowserPath, scenesQuery.refetch) | |||
There was a problem hiding this comment.
We are already calling useRealtime in FeathersChildReactor for each feathers request. Why do we need to do it again here?
There was a problem hiding this comment.
It's causing a referch for a different query
HexaField
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the
newSceneanddeleteScenefunctions use the file-browser api to create new scenes. Once the API responds, the scenes would refresh by listening to it.Subtasks Checklist
Breaking Changes
References
https://tsu.atlassian.net/browse/IR-2947
QA Steps